Summary

Add Git binary file patching.

Review Request #14714 — Created Nov. 28, 2025 and updated Nov. 28, 2025, 5:15 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds support to the GitPatcher for applying binary files
as part of changes. For git, this requires that we ask git apply to
exclude those particular files while applying, because otherwise it will
error out because there's no binary file data in the patch itself. We
then use the base patcher infrastructure for iterating through the
files, but provide overrides that can register adds, moves, and deletes
with git.

Testing Done


Ran unit tests.
Used rbt patch with a bunch of changes that did various file

  operations on binary files.

Commits

Summary	ID
Add Git binary file patching. This change adds support to the `GitPatcher` for applying binary files as part of changes. For git, this requires that we ask `git apply` to exclude those particular files while applying, because otherwise it will error out because there's no binary file data in the patch itself. We then use the base patcher infrastructure for iterating through the files, but provide overrides that can register adds, moves, and deletes with git. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	otvzyzqqpkzmkpnlkkwoyumrmozrlxol

Summary

Add Git binary file patching.

This change adds support to the `GitPatcher` for applying binary files as part of changes. For git, this requires that we ask `git apply` to exclude those particular files while applying, because otherwise it will error out because there's no binary file data in the patch itself. We then use the base patcher infrastructure for iterating through the files, but provide overrides that can register adds, moves, and deletes with git. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.

otvzyzqqpkzmkpnlkkwoyumrmozrlxol

Issues

Description	From	Last Updated
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 28, 2025, 5:15 p.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 28, 2025, 5:15 p.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 28, 2025, 5:15 p.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 28, 2025, 5:15 p.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 28, 2025, 5:15 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add Git binary file patching. This change adds support to the `GitPatcher` for applying binary files as part of changes. For git, this requires that we ask `git apply` to exclude those particular files while applying, because otherwise it will error out because there's no binary file data in the patch itself. We then use the base patcher infrastructure for iterating through the files, but provide overrides that can register adds, moves, and deletes with git. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	otvzyzqqpkzmkpnlkkwoyumrmozrlxol
	Add Git binary file patching. This change adds support to the `GitPatcher` for applying binary files as part of changes. For git, this requires that we ask `git apply` to exclude those particular files while applying, because otherwise it will error out because there's no binary file data in the patch itself. We then use the base patcher infrastructure for iterating through the files, but provide overrides that can register adds, moves, and deletes with git. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	otvzyzqqpkzmkpnlkkwoyumrmozrlxol

Diff:

Revision 2 (+1928 -16)

Show changes

	rbtools/clients/git.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.