Fix action-related deprecation warnings during tests.

 






 

 


  Review Request #14712
  —
  Created Nov. 28, 2025 and updated 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.1.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Previous changes for the actions rework introduced new deprecations.

This change modernizes some of our remaining actions in unit tests in

order to avoid some of them, and catches the rest where appropriate.


It also fixes a bug in ActionPlacement.depth that hits a deprecated

code path by checking the action's legacy depth property and not the

ActionPlacement.depth.

 








  


 
 

  
All unit tests pass.


Verified that there are no longer any deprecations from action code.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix action-related deprecation warnings during tests.
      
Previous changes for the actions rework introduced new deprecations.
This change modernizes some of our remaining actions in unit tests in
order to avoid some of them, and catches the rest where appropriate.

It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
code path by checking the action's legacy `depth` property and not the
`ActionPlacement.depth`.

     


    		
    38f0626f9443541102e58bec5d67d292d6d8bd9f

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
line too long (96 > 79 characters) Column: 80 Error code: E501

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused Column: 1 Error code: F401

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused Column: 1 Error code: F401

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 



















 




 

  


   

   

    
 
Checks run (1 failed, 1 succeeded)


    
   


  

  

  





 

 flake8
 failed.
 





 

 JSHint
 passed.
 













 
flake8

 


 










  

 





 














 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  









  

   

    Change Summary:
   

   

    
Removed an unused import.

   

  








  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Update remaining actions and fix warnings during tests.
      
Previous changes for the actions rework introduced new deprecations.
This change modernizes some of our remaining actions, both in production
code and unit tests, in order to avoid some of them, and catches the
rest where appropriate

It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
code path by checking the action's legacy `depth` property and not the
`ActionPlacement.depth`.

     


    		
    1ae7eff2743f190b4ea48347685660fcae692a28

   




   


    

    

     

      Update remaining actions and fix warnings during tests.
      
Previous changes for the actions rework introduced new deprecations.
This change modernizes some of our remaining actions, both in production
code and unit tests, in order to avoid some of them, and catches the
rest where appropriate

It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
code path by checking the action's legacy `depth` property and not the
`ActionPlacement.depth`.

     


    		
    96b65aedfa0d7848d76d2f7d57438cb59846ed57

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 2 (+356 -114)
Show changes
 
    reviewboard/actions/base.py 
    reviewboard/actions/tests/test_base_action.py 
    reviewboard/actions/tests/test_group_action.py 
    reviewboard/actions/tests/test_registry.py 
    reviewboard/extensions/tests/test_action_hooks.py 
    reviewboard/reviews/actions.py 
    reviewboard/reviews/tests/test_actions.py 
 

   

  











 

  
Checks run (1 failed, 1 succeeded)



  

 flake8
 failed.
 





  

 JSHint
 passed.
 





 







 
flake8

 


 















  

 
















 



 

  

   




chipx86




   

   

  

 



 















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Summary:
   

   

    
Update remaining actions and fix warnings during tests.
Fix action-related deprecation warnings during tests.

   

  





  

   

    Description:
   

   

    
     
Previous changes for the actions rework introduced new deprecations.
 ~   This change modernizes some of our remaining actions, both in production
 ~   code and unit tests, in order to avoid some of them, and catches the
   ~ This change modernizes some of our remaining actions in unit tests in
   ~ order to avoid some of them, and catches the rest where appropriate.
 -   rest where appropriate
     

     
It also fixes a bug in ActionPlacement.depth that hits a deprecated
     code path by checking the action's legacy depth property and not the
     ActionPlacement.depth.

   

  





  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Update remaining actions and fix warnings during tests.
      
Previous changes for the actions rework introduced new deprecations.
This change modernizes some of our remaining actions, both in production
code and unit tests, in order to avoid some of them, and catches the
rest where appropriate

It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
code path by checking the action's legacy `depth` property and not the
`ActionPlacement.depth`.

     


    		
    f312791104a4c3f85a7ed64c01508d4a0860ed18

   




   


    

    

     

      Fix action-related deprecation warnings during tests.
      
Previous changes for the actions rework introduced new deprecations.
This change modernizes some of our remaining actions in unit tests in
order to avoid some of them, and catches the rest where appropriate.

It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
code path by checking the action's legacy `depth` property and not the
`ActionPlacement.depth`.

     


    		
    38f0626f9443541102e58bec5d67d292d6d8bd9f

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 4 (+304 -104)
Show changes
 
    reviewboard/actions/base.py 
    reviewboard/actions/tests/test_base_action.py 
    reviewboard/actions/tests/test_group_action.py 
    reviewboard/actions/tests/test_registry.py 
    reviewboard/extensions/tests/test_action_hooks.py 
    reviewboard/reviews/tests/test_actions.py 
 

   

  











 

  
Checks run (2 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 passed.