Summary

Fix action-related deprecation warnings during tests.

Review Request #14712 — Created Nov. 29, 2025 and submitted Dec. 10, 2025, 9:10 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

It also fixes a bug in ActionPlacement.depth that hits a deprecated
code path by checking the action's legacy depth property and not the
ActionPlacement.depth.

Testing Done

All unit tests pass.

Verified that there are no longer any deprecations from action code.

Commits

Summary	ID
Fix action-related deprecation warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions in unit tests in order to avoid some of them, and catches the rest where appropriate. It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	38f0626f9443541102e58bec5d67d292d6d8bd9f

Summary

Fix action-related deprecation warnings during tests.

Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions in unit tests in order to avoid some of them, and catches the rest where appropriate. It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.

38f0626f9443541102e58bec5d67d292d6d8bd9f

Issues

Description	From	Last Updated
line too long (96 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 12:24 a.m.
'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 29, 2025, 12:24 a.m.
'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 29, 2025, 12:26 a.m.
This might wrap nicer if we call it parent instead of parent_action	david	Dec. 1, 2025, 11:31 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (96 > 79 characters)

Column: 80
Error code: E501
```

reviewboard/reviews/tests/test_actions.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Update remaining actions and fix warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions, both in production code and unit tests, in order to avoid some of them, and catches the rest where appropriate It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	1ae7eff2743f190b4ea48347685660fcae692a28
	Update remaining actions and fix warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions, both in production code and unit tests, in order to avoid some of them, and catches the rest where appropriate It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	96b65aedfa0d7848d76d2f7d57438cb59846ed57

Diff:

Revision 2 (+356 -114)

Show changes

	reviewboard/actions/base.py
	reviewboard/actions/tests/test_base_action.py
	reviewboard/actions/tests/test_group_action.py
	reviewboard/actions/tests/test_registry.py
	reviewboard/extensions/tests/test_action_hooks.py
	reviewboard/reviews/actions.py
	reviewboard/reviews/tests/test_actions.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_actions.py (Diff revision 2)

The issue has been resolved. Show all issues

'reviewboard.deprecation.RemovedInReviewBoard90Warning' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed another unused import.

Commits:

	Summary	ID
	Update remaining actions and fix warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions, both in production code and unit tests, in order to avoid some of them, and catches the rest where appropriate It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	96b65aedfa0d7848d76d2f7d57438cb59846ed57
	Update remaining actions and fix warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions, both in production code and unit tests, in order to avoid some of them, and catches the rest where appropriate It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	f312791104a4c3f85a7ed64c01508d4a0860ed18

Diff:

Revision 3 (+354 -114)

Show changes

	reviewboard/actions/base.py
	reviewboard/actions/tests/test_base_action.py
	reviewboard/actions/tests/test_group_action.py
	reviewboard/actions/tests/test_registry.py
	reviewboard/extensions/tests/test_action_hooks.py
	reviewboard/reviews/actions.py
	reviewboard/reviews/tests/test_actions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

Update remaining actions and fix warnings during tests.

Fix action-related deprecation warnings during tests.

Description:

		Previous changes for the actions rework introduced new deprecations.
~		This change modernizes some of our remaining actions, both in production
~		code and unit tests, in order to avoid some of them, and catches the
	~	This change modernizes some of our remaining actions in unit tests in
	~	order to avoid some of them, and catches the rest where appropriate.
-		rest where appropriate

		It also fixes a bug in `ActionPlacement.depth` that hits a deprecated
		code path by checking the action's legacy `depth` property and not the
		`ActionPlacement.depth`.

Commits:

	Summary	ID
	Update remaining actions and fix warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions, both in production code and unit tests, in order to avoid some of them, and catches the rest where appropriate It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	f312791104a4c3f85a7ed64c01508d4a0860ed18
	Fix action-related deprecation warnings during tests. Previous changes for the actions rework introduced new deprecations. This change modernizes some of our remaining actions in unit tests in order to avoid some of them, and catches the rest where appropriate. It also fixes a bug in `ActionPlacement.depth` that hits a deprecated code path by checking the action's legacy `depth` property and not the `ActionPlacement.depth`.	38f0626f9443541102e58bec5d67d292d6d8bd9f

Diff:

Revision 4 (+304 -104)

Show changes

	reviewboard/actions/base.py
	reviewboard/actions/tests/test_base_action.py
	reviewboard/actions/tests/test_group_action.py
	reviewboard/actions/tests/test_registry.py
	reviewboard/extensions/tests/test_action_hooks.py
	reviewboard/reviews/tests/test_actions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/actions/base.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This might wrap nicer if we call it parent instead of parent_action
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (9848aae)