Summary

Add typing to Review Bot's resources.

Review Request #14710 — Created Dec. 1, 2025 and updated Dec. 4, 2025, 9:28 p.m.

Owner

Repository

ReviewBot

Branch

release-4.x

Bugs

Depends On

Groups

People

Description

This adds typing to Review Bot's resources.

Testing Done

Used in an upcoming change.

Commits

Summary	ID
Add typing to Review Bot's resources. This adds typing to Review Bot's resources.	43a9d98a4a12bedeb2e5209ee4ba467e5055a635

Issues

Description	From	Last Updated
While here, can you update the name to use our standard naming? _normalize_comments_json?	chipx86	Dec. 4, 2025, 9:28 p.m.
It might be nice to define a TypedDict that documents/enforces the interface on this.	david	Dec. 4, 2025, 8:14 a.m.

flake8 passed.

JSHint passed.

Fix it!

extension/reviewbotext/resources.py (Diff revision 1)

An issue was opened. Show all issues

It might be nice to define a TypedDict that documents/enforces the interface on this.

Fix it!

extension/reviewbotext/resources.py (Diff revision 1)

An issue was opened. Show all issues

While here, can you update the name to use our standard naming? _normalize_comments_json?