Update for unicode compliance

 






 

 


  Review Request #147
  —
  Created Sept. 2, 2007 and submitted

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board SVN (deprecated)
 









 
 

  trunk
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Update various models and views for changes in the django unicode branch, according to the instructions at http://code.djangoproject.com/wiki/UnicodeBranch#PortingApplicationsTheQuickChecklist .  There should be
no real functional changes, other than avoiding errors when various things include unicode.

 








  


 
 

  
Ran unit tests, and made sure I could still upload and view a diff.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Awesome. Only one small thing, but it's debatable.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       /trunk/reviewboard/diffviewer/views.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Not sure we really need to convert cache keys, as they ultimately get turned into a str anyway.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      OK, I wasn't really sure, and I was too lazy to read the source.  Removed.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4.