Summary

Update for unicode compliance

Review Request #147 — Created Sept. 2, 2007 and submitted

Information

Owner

david

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Update various models and views for changes in the django unicode branch, according to the instructions at http://code.djangoproject.com/wiki/UnicodeBranch#PortingApplicationsTheQuickChecklist .  There should be
no real functional changes, other than avoiding errors when various things include unicode.

Testing Done

Ran unit tests, and made sure I could still upload and view a diff.

Expand All
Collapse All

Ship it!

Awesome. Only one small thing, but it's debatable.

/trunk/reviewboard/diffviewer/views.py (Diff revision 1)

Not sure we really need to convert cache keys, as they ultimately get turned into a str anyway.

david Sept. 2, 2007, 8:04 a.m.

OK, I wasn't really sure, and I was too lazy to read the source.  Removed.