Only render action models on the pages they apply to.

Review Request #14692 — Created Nov. 14, 2025 and updated

Information

Review Board
release-7.1.x

Reviewers

When rendering for models and views for actions were split up, we began
rendering the model JavaScript for every action on every page,
regardless of apply_to. This caused some actions to fail to
instantiate on pages they weren't supposed to be on.

This change restores a should_render() call for model JavaScript,
ensuring we only get the actions appropriate for the page.

Unit tests pass.

Verified that JavaScript unit tests were no longer erroring out with
actions that couldn't instantiate.

Summary ID
Only render action models on the pages they apply to.
When rendering for models and views for actions were split up, we began rendering the model JavaScript for every action on every page, regardless of `apply_to`. This caused some actions to fail to instantiate on pages they weren't supposed to be on. This change restores a `should_render()` call for model JavaScript, ensuring we only get the actions appropriate for the page.
62ecb2d3b5ebdce9db80f954a1075014bb67fcfc
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2.