Summary

Fix declarations for prototypeAttrs.

Review Request #14690 — Created Nov. 14, 2025 and updated Nov. 14, 2025, 3:20 p.m.

Information

Owner

david

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The new JS build for Ink uses the allowDeclareFields option for
@babel/preset-typescript, which will preserve any fields which are not
marked with declare (initializing to undefined). This caused our
type definitions to shadow the prototypeAttrs copied over by spina.

allowDeclareFields is the correct forward-looking thing to use, and
will be the default in Babel 8. This change fixes the resulting issue by
changing our type-only definitions to properly use declare.

Testing Done


Ran unit tests.
Verified that things like the dialog title worked again.

Commits

Summary	ID
Fix declarations for prototypeAttrs. The new JS build for Ink uses the `allowDeclareFields` option for `@babel/preset-typescript`, which will preserve any fields which are not marked with `declare` (initializing to `undefined`). This caused our type definitions to shadow the `prototypeAttr`s copied over by spina. `allowDeclareFields` is the correct forward-looking thing to use, and will be the default in Babel 8. This change fixes the resulting issue by changing our type-only definitions to properly use `declare`. Testing Done: - Ran unit tests. - Verified that things like the dialog title worked again.	rlvppkqmszynookryplxntyuzrunkqpo

Summary

Fix declarations for prototypeAttrs.

The new JS build for Ink uses the `allowDeclareFields` option for `@babel/preset-typescript`, which will preserve any fields which are not marked with `declare` (initializing to `undefined`). This caused our type definitions to shadow the `prototypeAttr`s copied over by spina. `allowDeclareFields` is the correct forward-looking thing to use, and will be the default in Babel 8. This change fixes the resulting issue by changing our type-only definitions to properly use `declare`. Testing Done: - Ran unit tests. - Verified that things like the dialog title worked again.

rlvppkqmszynookryplxntyuzrunkqpo

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```