adding clickability to summary td elements

 






 

 


  Review Request #1468
  —
  Created March 9, 2010 and submitted

 


















 

  

   Information

  





 
 

  dbuch-agi
 









 
 

  Djblets
 









 
 

  
 









 
 

  1022
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets, reviewboard
 









 
 

  chipx86, david, mcrute
 






 








 





  


 
 

  
This patch seeks to provide the behavior described by chipx86 in comment #4 on the issue detail page.

 








  


 
 

  
Lots of browser testing in Chrome.

Verified with Chrome debugger that click event is only attached to target "td.summary" elements.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/media/js/datagrid.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    First line in a multi-line comment shouldn't have any text.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/media/js/datagrid.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    These should be combined into one line. See the editButton.click above.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/media/js/datagrid.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Space between "if" and "("
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   





 DB





   

   

  

 



 















 



 

  

   





 DB





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Testing Done:
   

   

    
     
Lots of browser testing in Chrome.
   + 

   + 
Verified with Chrome debugger that click event is only attached to target "td.summary" elements.

   

  












  

 
















 





 

  

   





 DB





   

   





  

 



 

  


   

   

    
 
dbuch-agi


    
   


  

  

  



    




  1. 
 
    
  
    
   
    BUMP
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good. Pushed to djblets master as aa6f3a5.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Actually, I know that this was committed, but after looking at it again I realized the change was made in the wrong place. Djblets should not know anything about Summary cells. This is a Review Board-specific thing. This logic really should exist in Review Board and not in Djblets.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I actually don't think that this is a bad thing to have in djblets. It's not unusual for a datagrid to have a special column for the summary, and this is a pretty generic solution.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.