Summary

Provide the action's ID to the JavaScript model as "id".

Review Request #14661 — Created Oct. 31, 2025 and submitted Nov. 14, 2025, 5:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When actions were first implemented, the action's ID was provided to

the model as an actionId attribute. This wasn't marked as the model's

attribute, so it didn't properly function as an ID for lookup purposes.
To keep things clean and standard, this has been renamed to id. This

may have some theoretical fallout if anyone has actions with custom

views that reference this.get('actionId'), but it's unlikely any

third-parties will truly be affected. If needed, we could alias the ID.

Testing Done

Unit tests pass.

Commits

Summary	ID
Provide the action's ID to the JavaScript model as "id". When actions were first implemented, the action's ID was provided to the model as an `actionId` attribute. This wasn't marked as the model's attribute, so it didn't properly function as an ID for lookup purposes. To keep things clean and standard, this has been renamed to `id`. This may have some theoretical fallout if anyone has actions with custom views that reference `this.get('actionId')`, but it's unlikely any third-parties will truly be affected. If needed, we could alias the ID.	f82ac1a50c5f54fdecfb1b59b174f0956eef4175

Summary

Provide the action's ID to the JavaScript model as "id".

When actions were first implemented, the action's ID was provided to the model as an `actionId` attribute. This wasn't marked as the model's attribute, so it didn't properly function as an ID for lookup purposes. To keep things clean and standard, this has been renamed to `id`. This may have some theoretical fallout if anyone has actions with custom views that reference `this.get('actionId')`, but it's unlikely any third-parties will truly be affected. If needed, we could alias the ID.

f82ac1a50c5f54fdecfb1b59b174f0956eef4175

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:

Added a missing change from a subsequent commit to fix a bad variable.

Commits:

	Summary	ID
	Provide the action's ID to the JavaScript model as "id". When actions were first implemented, the action's ID was provided to the model as an `actionId` attribute. This wasn't marked as the model's attribute, so it didn't properly function as an ID for lookup purposes. To keep things clean and standard, this has been renamed to `id`. This may have some theoretical fallout if anyone has actions with custom views that reference `this.get('actionId')`, but it's unlikely any third-parties will truly be affected. If needed, we could alias the ID.	51be167af311d2c5b54e3a3189f18f077ec20a40
	Provide the action's ID to the JavaScript model as "id". When actions were first implemented, the action's ID was provided to the model as an `actionId` attribute. This wasn't marked as the model's attribute, so it didn't properly function as an ID for lookup purposes. To keep things clean and standard, this has been renamed to `id`. This may have some theoretical fallout if anyone has actions with custom views that reference `this.get('actionId')`, but it's unlikely any third-parties will truly be affected. If needed, we could alias the ID.	f82ac1a50c5f54fdecfb1b59b174f0956eef4175

Diff:

Revision 2 (+36 -48)

Show changes

	reviewboard/actions/base.py
	reviewboard/actions/tests/test_base_action.py
	reviewboard/actions/tests/test_base_action_renderer.py
	reviewboard/actions/tests/test_button_action_renderer.py
	reviewboard/actions/tests/test_default_action_group_renderer.py
	reviewboard/actions/tests/test_default_action_renderer.py
	reviewboard/actions/tests/test_detailed_menu_item_action_renderer.py
	reviewboard/actions/tests/test_group_action.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (f16ce20)