Summary

Update existing actions to use the new renderers.

Review Request #14660 — Created Oct. 29, 2025 and submitted Nov. 14, 2025, 5:08 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There's one notable architectural change here. We're now deprecating
is_custom_rendered(), which was introduced in Review Board 7 to
handle menu item actions that managed their own element style rather
than using the default Ink menu item rendering. This wasn't used for
anything else in practice, and isn't very usefully generic. Now, instead
of this function, menu item elements can set
data-custom-rendered="true", and the menu action will make use of its
element.

Testing Done

Unit tests passed.

Tested all the actions we have in the UI, and particularly the different
menu actions, making sure they rendered and were invoked correctly.

Checked to make sure we no longer had any deprecation warnings in the
devserver logs.

Commits

Summary	ID
Update existing actions to use the new renderers. This updates all of our actions with custom rendering to instead use the new renderer support. Most of these just set a default renderer or clear away rendering state (making use of the renderer from the parent group). Some implement small specialized custom renderers built for that action. There's one notable architectural change here. We're now deprecating `is_custom_rendered()`, which was introduced in Review Board 7 to handle menu item actions that managed their own element style rather than using the default Ink menu item rendering. This wasn't used for anything else in practice, and isn't very usefully generic. Now, instead of this function, menu item elements can set `data-custom-rendered="true"`, and the menu action will make use of its element.	d895c45600ca0a605fb19331cf8fa401331ad42d

Summary

Update existing actions to use the new renderers.

This updates all of our actions with custom rendering to instead use the new renderer support. Most of these just set a default renderer or clear away rendering state (making use of the renderer from the parent group). Some implement small specialized custom renderers built for that action. There's one notable architectural change here. We're now deprecating `is_custom_rendered()`, which was introduced in Review Board 7 to handle menu item actions that managed their own element style rather than using the default Ink menu item rendering. This wasn't used for anything else in practice, and isn't very usefully generic. Now, instead of this function, menu item elements can set `data-custom-rendered="true"`, and the menu action will make use of its element.

d895c45600ca0a605fb19331cf8fa401331ad42d

Issues

Description	From	Last Updated
Can we alphabetize these?	david	Nov. 10, 2025, 1:36 a.m.
'reviewboard.actions.renderers.DetailedMenuItemActionRenderer' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 10, 2025, 1:46 a.m.
Can we alphabetize these?	david	Nov. 10, 2025, 1:36 a.m.
Can we alphabetize these?	david	Nov. 10, 2025, 1:37 a.m.
Can we alphabetize these?	david	Nov. 10, 2025, 1:37 a.m.
Given that the frontend is no longer looking at the isCustomRendered attribute at all, can we document that in the …	david	Nov. 10, 2025, 1:44 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/actions.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.actions.renderers.DetailedMenuItemActionRenderer' imported but unused

Column: 1
Error code: F401

reviewboard/accounts/actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we alphabetize these?
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we alphabetize these?
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we alphabetize these?
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we alphabetize these?
```

reviewboard/static/rb/js/common/actions/views/menuActionView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Given that the frontend is no longer looking at the isCustomRendered attribute at all, can we document that in the model and mark that attribute as deprecated there too?

Change Summary:


Alphabetized attributes of affected actions.
Removed an unused import.
Added deprecation notices in JS docs for isCustomRendered.

Commits:

	Summary	ID
	Update existing actions to use the new renderers. This updates all of our actions with custom rendering to instead use the new renderer support. Most of these just set a default renderer or clear away rendering state (making use of the renderer from the parent group). Some implement small specialized custom renderers built for that action. There's one notable architectural change here. We're now deprecating `is_custom_rendered()`, which was introduced in Review Board 7 to handle menu item actions that managed their own element style rather than using the default Ink menu item rendering. This wasn't used for anything else in practice, and isn't very usefully generic. Now, instead of this function, menu item elements can set `data-custom-rendered="true"`, and the menu action will make use of its element.	d31cb6a8084fdeb75ca1a0b1d30e5655e0d7a191
	Update existing actions to use the new renderers. This updates all of our actions with custom rendering to instead use the new renderer support. Most of these just set a default renderer or clear away rendering state (making use of the renderer from the parent group). Some implement small specialized custom renderers built for that action. There's one notable architectural change here. We're now deprecating `is_custom_rendered()`, which was introduced in Review Board 7 to handle menu item actions that managed their own element style rather than using the default Ink menu item rendering. This wasn't used for anything else in practice, and isn't very usefully generic. Now, instead of this function, menu item elements can set `data-custom-rendered="true"`, and the menu action will make use of its element.	d895c45600ca0a605fb19331cf8fa401331ad42d

Diff:

Revision 2 (+186 -52)

Show changes

	reviewboard/accounts/actions.py
	reviewboard/actions/base.py
	reviewboard/actions/tests/test_detailed_menu_item_action_renderer.py
	reviewboard/reviews/actions.py
	reviewboard/static/rb/js/common/actions/models/actionModel.ts
	reviewboard/static/rb/js/common/actions/views/menuActionView.ts
	reviewboard/templates/actions/detailed_menuitem_action.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (ae2f2d1)