• 
      

    Fix processing of comments when there's no Review UI.

    Review Request #14657 — Created Oct. 28, 2025 and submitted

    Information

    Review Board
    release-7.1.x

    Reviewers

    When there's no Review UI for a file attachment, the thumbnail view
    itself allows adding a comment for a file. This was processing through
    the comments data expecting those to be an array, but after the work to
    add typing and make all the individual review UIs consistent, the data
    here is an object with arrays as the values. This change fixes it to
    properly iterate over that.

    Was able to add a new comment on a file attachment that did not have a
    review UI.

    Summary ID
    Fix processing of comments when there's no Review UI.
    When there's no Review UI for a file attachment, the thumbnail view itself allows adding a comment for a file. This was processing through the comments data expecting those to be an array, but after the work to add typing and make all the individual review UIs consistent, the data here is an object with arrays as the values. This change fixes it to properly iterate over that. Testing Done: Was able to add a new comment on a file attachment that did not have a review UI.
    swkkpukwoyrtwrspzuukmwlqpnytturw
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.1.x (8fae305)