Summary

Add suppress checkboxes and better ARIA roles for dialogs.

Review Request #14649 — Created Oct. 24, 2025 and submitted Nov. 25, 2025, 6:07 p.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

It's common for some types of dialogs to have a suppression checkbox,
such as "Do not ask again." To ensure there's a standard approach for
this, dialogs can now have canSuppress=true set. This will place a
checkbox in the secondary actions area, at the far left.

The default text will be "Do not ask again," but this can be customized
by setting suppressText=.

It's up to the caller to determine how to suppress. The dialog doesn't
control any of this. It does provide the result of the checkbox though
as an isSuppressed property.

This will be used for upcoming confirmation utility dialogs.

Along with this, the ARIA role for modal dialogs has been updated to use
alertdialog. This will announce the dialog to screen readers, and is
the correct choice when popping up a modal dialog that requires
attention, rather than a utility dialog that is simply on screen.

Testing Done

Tested with and without suppression checkboxes, and with custom
label text.

Commits

Summary	ID
Add suppress checkboxes and better ARIA roles for dialogs. It's common for some types of dialogs to have a suppression checkbox, such as "Do not ask again." To ensure there's a standard approach for this, dialogs can now have `canSuppress=true` set. This will place a checkbox in the secondary actions area, at the far left. The default text will be "Do not ask again," but this can be customized by setting `suppressText=`. It's up to the caller to determine how to suppress. The dialog doesn't control any of this. It does provide the result of the checkbox though as an `isSuppressed` property. This will be used for upcoming confirmation utility dialogs. Along with this, the ARIA role for modal dialogs has been updated to use `alertdialog`. This will announce the dialog to screen readers, and is the correct choice when popping up a modal dialog that requires attention, rather than a utility dialog that is simply on screen.	c936311c0af0c07840f4cbe3249c4fc80ec38d66

Summary

Add suppress checkboxes and better ARIA roles for dialogs.

It's common for some types of dialogs to have a suppression checkbox, such as "Do not ask again." To ensure there's a standard approach for this, dialogs can now have `canSuppress=true` set. This will place a checkbox in the secondary actions area, at the far left. The default text will be "Do not ask again," but this can be customized by setting `suppressText=`. It's up to the caller to determine how to suppress. The dialog doesn't control any of this. It does provide the result of the checkbox though as an `isSuppressed` property. This will be used for upcoming confirmation utility dialogs. Along with this, the ARIA role for modal dialogs has been updated to use `alertdialog`. This will announce the dialog to screen readers, and is the correct choice when popping up a modal dialog that requires attention, rather than a utility dialog that is simply on screen.

c936311c0af0c07840f4cbe3249c4fc80ec38d66

Files

Issues

Description	From	Last Updated
I think I'd prefer if this was named something like isSuppressChecked. isSuppressed makes me think the dialog will handle the …	david	Nov. 25, 2025, 12:43 p.m.
Seems like this should be id= or name=. This also needs the ink-c-dialog__suppress class to match the styling/docs elsewhere.	david	Nov. 25, 2025, 12:44 p.m.
What does this mean?	david	Nov. 25, 2025, 12:45 p.m.
This should be __suppress, to match the comment.	david	Nov. 25, 2025, 12:46 p.m.
This should have defaults for canSuppress and suppressText	david	Nov. 25, 2025, 12:47 p.m.

flake8 passed.

JSHint passed.

src/ink/js/components/views/dialogView.ts (Diff revision 1)

The issue has been resolved. Show all issues

I think I'd prefer if this was named something like isSuppressChecked. isSuppressed makes me think the dialog will handle the suppression.

src/ink/js/components/views/dialogView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Seems like this should be id= or name=.
This also needs the ink-c-dialog__suppress class to match the styling/docs elsewhere.

chipx86 Nov. 25, 2025, 12:47 p.m.

Looks like this fix ended up in /r/14689/. Moving it back here.

src/ink/less/components/schemas/dialog.schema.less (Diff revision 1)

The issue has been dropped. Show all issues

What does this mean?

chipx86 Nov. 25, 2025, 12:47 p.m.

This is part of the schema documentation format I introduced in Ink. Meant to be a more formal way of showing how many of a component part can/must be in an element. It's used throughout the codebase.

src/ink/less/components/schemas/dialog.schema.less (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be __suppress, to match the comment.
```

src/stories/components/dialog.stories.ts (Diff revision 1)

The issue has been dropped. Show all issues

This should have defaults for canSuppress and suppressText

chipx86 Nov. 25, 2025, 12:47 p.m.

Only if we want to supply a value. This is specifically using defaults.

Change Summary:


Renamed the accessor to isSuppressChecked().
Added the missing/fixed id= and class= for the input ID (ended up in /r/14689/).
Fixed the selector for the suppress checkbox.

Commits:

	Summary	ID
	Add suppress checkboxes and better ARIA roles for dialogs. It's common for some types of dialogs to have a suppression checkbox, such as "Do not ask again." To ensure there's a standard approach for this, dialogs can now have `canSuppress=true` set. This will place a checkbox in the secondary actions area, at the far left. The default text will be "Do not ask again," but this can be customized by setting `suppressText=`. It's up to the caller to determine how to suppress. The dialog doesn't control any of this. It does provide the result of the checkbox though as an `isSuppressed` property. This will be used for upcoming confirmation utility dialogs. Along with this, the ARIA role for modal dialogs has been updated to use `alertdialog`. This will announce the dialog to screen readers, and is the correct choice when popping up a modal dialog that requires attention, rather than a utility dialog that is simply on screen.	af215fdc1c682e555c1afd3a8cd77227f52cb0cc
	Add suppress checkboxes and better ARIA roles for dialogs. It's common for some types of dialogs to have a suppression checkbox, such as "Do not ask again." To ensure there's a standard approach for this, dialogs can now have `canSuppress=true` set. This will place a checkbox in the secondary actions area, at the far left. The default text will be "Do not ask again," but this can be customized by setting `suppressText=`. It's up to the caller to determine how to suppress. The dialog doesn't control any of this. It does provide the result of the checkbox though as an `isSuppressed` property. This will be used for upcoming confirmation utility dialogs. Along with this, the ARIA role for modal dialogs has been updated to use `alertdialog`. This will announce the dialog to screen readers, and is the correct choice when popping up a modal dialog that requires attention, rather than a utility dialog that is simply on screen.	c936311c0af0c07840f4cbe3249c4fc80ec38d66

Diff:

Revision 2 (+320 -40)

Show changes

	src/ink/js/components/views/dialogView.ts
	src/ink/less/components/dialog.component.less
	src/ink/less/components/schemas/dialog.schema.less
	src/stories/components/dialog.stories.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (01d672e)