Summary

Modernize jasmine-suites build and install.

Review Request #14636 — Created Oct. 15, 2025 and submitted Dec. 16, 2025, 9:23 p.m.

Information

Owner

david

Repository

jasmine-suites

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

This change modernizes our jasmine-suites package in many ways:

Ported the code to TypeScript.
Moved .babelrc to babel.config.json
Changed dependencies so we use @babel/js-buildkit and

@babel/frontend-buildkit as the meta-packages that pull in

  everything we need to build, and instead of depending on jasmine

  (which is the node CLI package for running tests), we have a peer

  dependency on jasmine-core.
Set our minimum jasmine dependency as 5.0+.
Added an ESLint config.

Testing Done

Built the package and used it from Review Board.

Commits

Summary	ID
Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Summary

Modernize jasmine-suites build and install.

This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.

kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Issues

Description	From	Last Updated
Should we also say "Support for Jasmine 5.0+" here.	maubin	Oct. 27, 2025, 2:19 p.m.
This is missing "Args" and "Returns" sections in its docs.	maubin	Oct. 27, 2025, 2:19 p.m.

flake8 passed.

JSHint passed.

Change Summary:


List imports for cjs and esm, along with types files.
Fix global symbol used in rollup config so we're compatible with both browsers and node.
Remove assertion about jasmine version, since that should be pretty well handled through package dependencies now.

Commits:

	Summary	ID
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Diff:

Revision 2 (+10270 -9044)

Show changes

	.gitignore
	LICENSE
	NEWS.md
	README.md
	babel.config.json
	eslint.config.mjs
	package.json
	package-lock.json
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Update eslint config for new flat config.

Commits:

	Summary	ID
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Diff:

Revision 3 (+10232 -9044)

Show changes

	.gitignore
	LICENSE
	NEWS.md
	README.md
	babel.config.json
	eslint.config.mjs
	package.json
	package-lock.json
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Exclude package-lock.json from the posted diff for easier reviewing.

Commits:

	Summary	ID
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Diff:

Revision 4 (+774 -486)

Show changes

	.gitignore
	LICENSE
	NEWS.md
	README.md
	babel.config.json
	eslint.config.mjs
	package.json
	rollup.config.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

NEWS.md (Diff revision 4)

The issue has been resolved. Show all issues

Should we also say "Support for Jasmine 5.0+" here.

david Oct. 27, 2025, 2:20 p.m.

Older versions supported this too. I'll clarify that we dropped support for Jasmine 4.x.

src/index.ts (Diff revision 4)
The issue has been resolved. Show all issues
```
This is missing "Args" and "Returns" sections in its docs.
```

Commits:

	Summary	ID
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw
	Modernize jasmine-suites build and install. This change modernizes our jasmine-suites package in many ways: * Ported the code to TypeScript. * Moved `.babelrc` to `babel.config.json` * Changed dependencies so we use `@babel/js-buildkit` and `@babel/frontend-buildkit` as the meta-packages that pull in everything we need to build, and instead of depending on `jasmine` (which is the node CLI package for running tests), we have a peer dependency on `jasmine-core`. * Set our minimum jasmine dependency as 5.0+. * Added missing NEWS.md and LICENSE files. * Added an ESLint config. Testing Done: Built the package and used it from Review Board.	kvmqwzylsytpwvmpksvlyxmppxwnkqrw

Diff:

Revision 5 (+792 -486)

Show changes

	.gitignore
	LICENSE
	NEWS.md
	README.md
	babel.config.json
	eslint.config.mjs
	package.json
	rollup.config.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed