Summary

Add get_http_request_ip for fetching a requester's IP address.

Review Request #14630 — Created Nov. 28, 2025 and submitted Dec. 1, 2025, 3:58 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

djblets.http.get_http_request_ip returns the IP address stored in the
the X-Real-IP or X-Forwarded-For headers (if available), falling
back to the raw client IP address if needed.

Since this operates off of HTTP headers, it's up to the configured
servers to ensure any client-provided headers are stripped out and that
these are set to trusted values.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add get_http_request_ip for fetching a requester's IP address. `djblets.http.get_http_request_ip` returns the IP address stored in the the `X-Real-IP` or `X-Forwarded-For` headers (if available), falling back to the raw client IP address if needed. Since this operates off of HTTP headers, it's up to the configured servers to ensure any client-provided headers are stripped out and that these are set to trusted values.	00059f1d754e74df40b5982ff8ff5a55a2a3fe2e

Summary

Add get_http_request_ip for fetching a requester's IP address.

`djblets.http.get_http_request_ip` returns the IP address stored in the the `X-Real-IP` or `X-Forwarded-For` headers (if available), falling back to the raw client IP address if needed. Since this operates off of HTTP headers, it's up to the configured servers to ensure any client-provided headers are stripped out and that these are set to trusted values.

00059f1d754e74df40b5982ff8ff5a55a2a3fe2e

Issues

Description	From	Last Updated
Please add a module docstring.	david	Dec. 1, 2025, 3:57 a.m.

flake8 passed.

JSHint passed.

Ship it!

djblets/http/tests/test_requests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Please add a module docstring.
```

Change Summary:

Added a missing docstring to the unit tests file.

Commits:

	Summary	ID
	Add get_http_request_ip for fetching a requester's IP address. `djblets.http.get_http_request_ip` returns the IP address stored in the the `X-Real-IP` or `X-Forwarded-For` headers (if available), falling back to the raw client IP address if needed. Since this operates off of HTTP headers, it's up to the configured servers to ensure any client-provided headers are stripped out and that these are set to trusted values.	af98fe0b724bc04dcd0e1e9973242c40240f0fdb
	Add get_http_request_ip for fetching a requester's IP address. `djblets.http.get_http_request_ip` returns the IP address stored in the the `X-Real-IP` or `X-Forwarded-For` headers (if available), falling back to the raw client IP address if needed. Since this operates off of HTTP headers, it's up to the configured servers to ensure any client-provided headers are stripped out and that these are set to trusted values.	00059f1d754e74df40b5982ff8ff5a55a2a3fe2e

Diff:

Revision 2 (+256)

Show changes

	djblets/http/requests.py
	djblets/http/tests/test_requests.py
	docs/djblets/coderef/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to release-5.x (a6ccda2)