Summary

Support session tokens and non-JSON responses for license checks.

Review Request #14613 — Created Sept. 14, 2025 and submitted Sept. 19, 2025, 1:47 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Responses are also no longer required to be JSON. A license server may
now provide any kind of text-based response, which may be processed by
the License Provider however needed.

Testing Done

Unit tests pass.

Tested this with the in-progress work in Power Pack.

Commits

Summary	ID
Support session tokens and non-JSON responses for license checks. When preparing for a license check on the Licenses page, a License Provider can now provide a Session Token, which is an opaque value that will be passed back during processing of a response. That allows information to be temporarily stored and then retrieved for response processing. Responses are also no longer required to be JSON. A license server may now provide any kind of text-based response, which may be processed by the License Provider however needed.	9f63025340821609c03b18c99ccd6751013ac4ce

Summary

Support session tokens and non-JSON responses for license checks.

When preparing for a license check on the Licenses page, a License Provider can now provide a Session Token, which is an opaque value that will be passed back during processing of a response. That allows information to be temporarily stored and then retrieved for response processing. Responses are also no longer required to be JSON. A license server may now provide any kind of text-based response, which may be processed by the License Provider however needed.

9f63025340821609c03b18c99ccd6751013ac4ce

Issues

Description	From	Last Updated
Given that content-type headers can include other info like charsets, and are not case sensitive, we probably should do something …	david	Sept. 17, 2025, 1:51 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/admin/models/licenseModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Given that content-type headers can include other info like charsets, and are not case sensitive, we probably should do something like:

const contentType = response.headers['content-type'].toLowerCase()

if (contentType.includes('application/json') {

Change Summary:

Added better mimetype handling. Now application/json prefixes and +json suffixes are supported, and casing is normalized.

Commits:

	Summary	ID
	Support session tokens and non-JSON responses for license checks. When preparing for a license check on the Licenses page, a License Provider can now provide a Session Token, which is an opaque value that will be passed back during processing of a response. That allows information to be temporarily stored and then retrieved for response processing. Responses are also no longer required to be JSON. A license server may now provide any kind of text-based response, which may be processed by the License Provider however needed.	3c7f540ab1ef1b5cd35eaef896b636af9db3ce4a
	Support session tokens and non-JSON responses for license checks. When preparing for a license check on the Licenses page, a License Provider can now provide a Session Token, which is an opaque value that will be passed back during processing of a response. That allows information to be temporarily stored and then retrieved for response processing. Responses are also no longer required to be JSON. A license server may now provide any kind of text-based response, which may be processed by the License Provider however needed.	9f63025340821609c03b18c99ccd6751013ac4ce

Diff:

Revision 2 (+110 -6)

Show changes

	reviewboard/licensing/license_checks.py
	reviewboard/licensing/provider.py
	reviewboard/licensing/tests/providers.py
	reviewboard/licensing/tests/test_license_provider.py
	reviewboard/licensing/tests/test_licenses_view.py
	reviewboard/static/rb/js/admin/models/licenseModel.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (433a1ec)