Summary

Rewrite HealthCheckViewTests to not override CACHES.

Review Request #14612 — Created Sept. 12, 2025 and submitted Sept. 15, 2025, 7:52 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Apparently, using @override_settings(CACHES=...) is not safe, and can
break later tests even though the setting is restored. This change
updates our view to encapsulate the cache checking in a couple methods
which can be safely spied on instead, the same way we do for
DATABASES.

Testing Done

Ran unit tests and saw that everything passed.

Commits

Summary	ID
Rewrite HealthCheckViewTests to not override CACHES. Apparently, using `@override_settings(CACHES=...)` is not safe, and can break later tests even though the setting is restored. This change updates our view to encapsulate the cache checking in a couple methods which can be safely spied on instead, the same way we do for `DATABASES`. Testing Done: Ran unit tests and saw that everything passed.	knynxrwwwssnpmpzzuxmsxtptzyvqqwo

Issues

Description	From	Last Updated
Leftover debugging.	chipx86	Sept. 15, 2025, 7:49 a.m.

flake8 passed.

JSHint passed.

Ship it!

djblets/util/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Leftover debugging.
```

Status:: Completed
Change Summary:: Pushed to release-5.x (66f6aaa)

djblets/util/views.py (Diff revision 1)