Summary

Copy perforce repo data for unit tests.

Review Request #14609 — Created Sept. 11, 2025 and submitted Sept. 15, 2025, 8:08 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The new unit tests that use a local p4d had an issue where the db.user
file got updated (likely with a login timestamp) when running the tests.
In order to prevent this file from getting updated every time we run
tests, we now make a copy of the repo data for the duration of the test
suite.

Testing Done

Ran test_perforce.py tests and saw that db.user was no longer modified
in my local checkout.

Commits

Summary	ID
Copy perforce repo data for unit tests. The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.	mwkkzzsqsqttsvqstnzosqnozpxzuuxm

Summary

Copy perforce repo data for unit tests.

The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.

mwkkzzsqsqttsvqstnzosqnozpxzuuxm

Issues

Description	From	Last Updated
'shutil.copytree' imported but unused Column: 1 Error code: F401	reviewbot	Sept. 11, 2025, 2:34 p.m.
Thinking we should probably do a try/finally and put the rmtree in the finally, so it doesn't end up leaving …	chipx86	Sept. 15, 2025, 8:15 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'shutil.copytree' imported but unused

Column: 1
Error code: F401
```

Commits:

	Summary	ID
	Copy perforce repo data for unit tests. The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.	mwkkzzsqsqttsvqstnzosqnozpxzuuxm
	Copy perforce repo data for unit tests. The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.	mwkkzzsqsqttsvqstnzosqnozpxzuuxm

Diff:

Revision 2 (+18 -4)

Show changes

reviewboard/scmtools/tests/test_perforce.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/scmtools/tests/test_perforce.py (Diff revision 2)

The issue has been resolved. Show all issues

Thinking we should probably do a try/finally and put the rmtree in the finally, so it doesn't end up leaving files around. Though I guess the question is then, if the process does not terminate, do we want to delete the files...

Commits:

	Summary	ID
	Copy perforce repo data for unit tests. The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.	mwkkzzsqsqttsvqstnzosqnozpxzuuxm
	Copy perforce repo data for unit tests. The new unit tests that use a local p4d had an issue where the db.user file got updated (likely with a login timestamp) when running the tests. In order to prevent this file from getting updated every time we run tests, we now make a copy of the repo data for the duration of the test suite. Testing Done: Ran test_perforce.py tests and saw that db.user was no longer modified in my local checkout.	mwkkzzsqsqttsvqstnzosqnozpxzuuxm

Branch:

master

release-7.x

Diff:

Revision 3 (+22 -6)

Show changes

reviewboard/scmtools/tests/test_perforce.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (f1ec80a)