Summary

Add support for Forgejo.

Review Request #14607 — Created Sept. 10, 2025 and submitted Oct. 7, 2025, 7:52 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Forgejo is a newish open-source code forge system forked from Gitea
which has been rapidly gaining popularity. This change adds hosting
service support for it.

This implementation handles all of the main parts of integration for the
hosting service, including:

Authorization with the service, creating a new API token for the user
with the correct permissions.
Basic support for getting file content (git blobs).
Post-commit review support, fetching branches, lists of commits, commit
data, and diffs.
Bug tracker integration, including linking to issues and showing the
bug infobox.
WebHook support for closing review requests when commits are pushed.

The only hosting service feature which is not implemented is the remote
repository listing.

Testing Done


Tested authorization and API token creation, including when 2FA was

  enabled.
Verified pre-commit and post-commit review functionality against a

  self-hosted Forgejo server.
Checked linking to bugs and the bug infobox.
Verified that setting up a WebHook according to the instructions worked

  correctly, and that pushing code to Forgejo properly closed relevant

  review requests.
Ran unit tests.

Commits

Summary	ID
Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Summary

Add support for Forgejo.

Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.

zupounommokpsrpqoprqqltlnnwoyztv

Issues

Description	From	Last Updated
continuation line unaligned for hanging indent Column: 25 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
closing bracket does not match indentation of opening bracket's line Column: 13 Error code: E123	reviewbot	Sept. 10, 2025, 4:51 p.m.
closing bracket does not match indentation of opening bracket's line Column: 9 Error code: E123	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 13 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
closing bracket does not match indentation of opening bracket's line Column: 13 Error code: E123	reviewbot	Sept. 10, 2025, 4:51 p.m.
closing bracket does not match indentation of opening bracket's line Column: 9 Error code: E123	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line under-indented for visual indent Column: 25 Error code: E128	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line under-indented for visual indent Column: 25 Error code: E128	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line unaligned for hanging indent Column: 20 Error code: E131	reviewbot	Sept. 10, 2025, 4:51 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line under-indented for visual indent Column: 13 Error code: E128	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line under-indented for visual indent Column: 13 Error code: E128	reviewbot	Sept. 10, 2025, 4:51 p.m.
continuation line under-indented for visual indent Column: 25 Error code: E128	reviewbot	Sept. 10, 2025, 4:54 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 10, 2025, 4:54 p.m.
Typo: Initialie	maubin	Sept. 19, 2025, 7:33 a.m.
Get rid of the "is" here.	maubin	Sept. 19, 2025, 7:33 a.m.
Would should handle the potential ValidationError here as well.	maubin	Sept. 19, 2025, 7:35 a.m.
We have error = data.decode() above so we can pass that to .format() instead of decoding again. Might as well …	maubin	Sept. 19, 2025, 7:37 a.m.
Since we can only hit this case if a two factor auth code was already provided by the user, I …	maubin	Sept. 19, 2025, 7:38 a.m.
Was this meant to say "username" instead of "login"?	maubin	Sept. 19, 2025, 7:38 a.m.
Since this error is moreso user facing than just admin facing (it'd be displayed in the diff viewer, right?) maybe …	maubin	Sept. 19, 2025, 7:39 a.m.
We can get rid of this text.	maubin	Sept. 19, 2025, 7:40 a.m.
Can you type these as well.	maubin	Sept. 19, 2025, 7:40 a.m.
What if both sha and branch are not provided, shouldn't we use the default branch? Should have a unit test …	maubin	Sept. 19, 2025, 8 a.m.
Can you add this to the "Raises" docs as well.	maubin	Sept. 22, 2025, 7:24 a.m.
Note that this is still TODO.	maubin	Sept. 19, 2025, 8:02 a.m.
Is this correct syntax? Does it work for RB7.1's supported Python versions?	maubin	Sept. 19, 2025, 8:02 a.m.
This can fit on one line. Or are we always meant to put the format args on the next line …	maubin	Sept. 19, 2025, 8:02 a.m.
Nit: I think it'd be nice to standardize on including a trailing slash in the URLs, for methods that return …	maubin	Sept. 19, 2025, 8:04 a.m.
This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).	maubin	Sept. 19, 2025, 8:05 a.m.
This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).	maubin	Sept. 19, 2025, 8:05 a.m.
This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).	maubin	Sept. 19, 2025, 8:05 a.m.
Do you know if Forgejo has a limit on API token name length? If so we'll have to cap it …	maubin	Sept. 19, 2025, 8:43 a.m.
These should be swapped.	chipx86	Oct. 6, 2025, 8:32 a.m.
I think both of these can live in TYPE_CHECKING.	chipx86	Oct. 6, 2025, 8:33 a.m.
Can we pull this out into a separate variable? Gets a bit wordy with a call inside this, and one …	chipx86	Oct. 6, 2025, 8:34 a.m.
Are we able to assert this instead of casting?	chipx86	Oct. 6, 2025, 8:34 a.m.
We can probably remove the prefix, since the logger will have those details.	chipx86	Oct. 6, 2025, 8:55 a.m.
We should escape the username.	chipx86	Oct. 6, 2025, 8:59 a.m.
Lowercase "application".	chipx86	Oct. 6, 2025, 8:35 a.m.
We may want to set up and reference a trace ID in this, point people to the logs.	chipx86	Oct. 6, 2025, 9:05 a.m.
Can we stick with one per line, like a dictionary?	chipx86	Oct. 6, 2025, 8:36 a.m.
We should escape the SHA.	chipx86	Oct. 6, 2025, 8:59 a.m.
Same question here and probably below re: asserting.	chipx86	Oct. 6, 2025, 8:37 a.m.
Same as above, let's stick with one keyword argument per line. Makes it easier to read and maintain.	chipx86	Oct. 6, 2025, 8:38 a.m.
We should escape the revision.	chipx86	Oct. 6, 2025, 8:59 a.m.
Same here.	chipx86	Oct. 6, 2025, 8:59 a.m.
This is accessed 2 times per line. Let's pull it out into a local variable in the get_change.	chipx86	Oct. 6, 2025, 8:38 a.m.
Is there consistency in how long the partial SHA is? If so, we can clip these in all_shas above and …	chipx86	Oct. 6, 2025, 8:40 a.m.
Same here.	chipx86	Oct. 6, 2025, 8:40 a.m.
We should escape bug_id.	chipx86	Oct. 6, 2025, 9 a.m.
We should escape these.	chipx86	Oct. 6, 2025, 9 a.m.
We should escape the commit.	chipx86	Oct. 6, 2025, 9 a.m.
The "subclasses" part should be reworked.	chipx86	Oct. 6, 2025, 8:41 a.m.
We should escape the repository owner and name.	chipx86	Oct. 6, 2025, 8:57 a.m.
To make this a tad less verbose, can we pull out service_class?	chipx86	Oct. 6, 2025, 8:41 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 25
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```

reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

closing bracket does not match indentation of opening bracket's line

Column: 13
Error code: E123

reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

closing bracket does not match indentation of opening bracket's line

Column: 9
Error code: E123

reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```
reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 13
Error code: E131
```

reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

closing bracket does not match indentation of opening bracket's line

Column: 13
Error code: E123

reviewboard/hostingsvcs/forgejo/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

closing bracket does not match indentation of opening bracket's line

Column: 9
Error code: E123

reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 25
Error code: E128
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 25
Error code: E128
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 20
Error code: E131
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 13
Error code: E128
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 13
Error code: E128
```

Commits:

	Summary	ID
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Diff:

Revision 2 (+6046)

Show changes

	reviewboard/dependencies.py
	reviewboard/hostingsvcs/base/registry.py
	reviewboard/hostingsvcs/forgejo/__init__.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/forgejo/errors.py
	reviewboard/hostingsvcs/forgejo/forms.py
	reviewboard/hostingsvcs/forgejo/service.py
	3 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 2)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 25
Error code: E128
```
reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Diff:

Revision 3 (+6048)

Show changes

	reviewboard/dependencies.py
	reviewboard/hostingsvcs/base/registry.py
	reviewboard/hostingsvcs/forgejo/__init__.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/forgejo/errors.py
	reviewboard/hostingsvcs/forgejo/forms.py
	reviewboard/hostingsvcs/forgejo/service.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Typo: Initialie
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Get rid of the "is" here.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Would should handle the potential ValidationError here as well.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

We have error = data.decode() above so we can pass that to .format() instead of decoding again. Might as well make a variable for e.code too and use that in the error log and here.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been dropped. Show all issues

Since we can only hit this case if a two factor auth code was already provided by the user, I feel like a more appropriate message would just be "Invalid two-factor authentication code."

david Sept. 19, 2025, 8:48 a.m.

We get this both if the code was invalid but also when we first try to authenticate with just username+password (which is what makes us show the OTP field in the first place)

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Was this meant to say "username" instead of "login"?
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

Since this error is moreso user facing than just admin facing (it'd be displayed in the diff viewer, right?) maybe we should say something like "Please contact your administrator to review the Review Board log files ...".

david Sept. 19, 2025, 8:48 a.m.

I'll just simplify it to the first sentence. I feel like contacting an admin is a predictable step if someone is getting a weird error.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We can get rid of this text.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Can you type these as well.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

What if both sha and branch are not provided, shouldn't we use the default branch? Should have a unit test for this case as well.

david Sept. 19, 2025, 8:48 a.m.

The calling code will always provide one. I'll add some validation for this case.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Note that this is still TODO.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

Is this correct syntax? Does it work for RB7.1's supported Python versions?

david Sept. 19, 2025, 8:48 a.m.

Ah nope, was still syntax from when this was on the master branch.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

This can fit on one line. Or are we always meant to put the format args on the next line irregardless of the length of the string? I forget.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 3)

The issue has been resolved. Show all issues

Nit: I think it'd be nice to standardize on including a trailing slash in the URLs, for methods that return URLs. So that in the future if someone's using _get_api_root or _get_api_repo_root, they wouldn't have to check which one has a trailing slash and which one doesn't.

david Sept. 19, 2025, 8:48 a.m.

Forgejo API URLs don't use trailing slashes. I think I'll change it so _get_api_root() returns it without, and then we always add a slash where we use it.

reviewboard/hostingsvcs/forgejo/service.py (Diff revision 3)

The issue has been dropped. Show all issues

This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).

david Sept. 19, 2025, 8:48 a.m.

HostingServiceAPIError is a subclass of HostingServiceError, and the code that calls these things pretty universally is only catching HostingServiceError

reviewboard/hostingsvcs/forgejo/service.py (Diff revision 3)

The issue has been dropped. Show all issues

This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).

reviewboard/hostingsvcs/forgejo/service.py (Diff revision 3)

The issue has been dropped. Show all issues

This could also raise HostingServiceAPIError (update the docstring in the corresponding ForgejoClient method too).

reviewboard/hostingsvcs/forgejo/service.py (Diff revision 3)

The issue has been resolved. Show all issues

Do you know if Forgejo has a limit on API token name length? If so we'll have to cap it here, in case someone's server name is super long.

david Sept. 19, 2025, 8:48 a.m.

Looks like in their UI the field is limited to 255.

Commits:

	Summary	ID
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Diff:

Revision 4 (+6106)

Show changes

	reviewboard/dependencies.py
	reviewboard/hostingsvcs/base/registry.py
	reviewboard/hostingsvcs/forgejo/__init__.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/forgejo/errors.py
	reviewboard/hostingsvcs/forgejo/forms.py
	reviewboard/hostingsvcs/forgejo/service.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Also just making a note here that we'll need to update the Review Board documentation for Forgejo.

reviewboard/hostingsvcs/forgejo/client.py (Diff revisions 3 - 4)
The issue has been resolved. Show all issues
```
Can you add this to the "Raises" docs as well.
```

Commits:

	Summary	ID
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Diff:

Revision 5 (+6112)

Show changes

	reviewboard/dependencies.py
	reviewboard/hostingsvcs/base/registry.py
	reviewboard/hostingsvcs/forgejo/__init__.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/forgejo/errors.py
	reviewboard/hostingsvcs/forgejo/forms.py
	reviewboard/hostingsvcs/forgejo/service.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These should be swapped.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
I think both of these can live in TYPE_CHECKING.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)

The issue has been resolved. Show all issues

Can we pull this out into a separate variable? Gets a bit wordy with a call inside this, and one of my plans around 8/9 timeframe's going to be revisiting calls like decrypt_password() to enable rotatable keys, which will require some additional complexity.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Are we able to assert this instead of casting?
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We can probably remove the prefix, since the logger will have those details.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape the username.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Lowercase "application".
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We may want to set up and reference a trace ID in this, point people to the logs.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Can we stick with one per line, like a dictionary?
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape the SHA.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same question here and probably below re: asserting.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)

The issue has been resolved. Show all issues

Same as above, let's stick with one keyword argument per line. Makes it easier to read and maintain.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape the revision.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same here.
```

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)

The issue has been resolved. Show all issues

This is accessed 2 times per line. Let's pull it out into a local variable in the get_change.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)

The issue has been dropped. Show all issues

Is there consistency in how long the partial SHA is? If so, we can clip these in all_shas above and then just do a lookup.

david Oct. 6, 2025, 9:10 a.m.

Not necessarily. It's at least 6, but in repos with lots of commits (like RB's) where that could create conflicts, partial SHAs are longer.

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape bug_id.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape these.
```
reviewboard/hostingsvcs/forgejo/client.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape the commit.
```
reviewboard/hostingsvcs/forgejo/service.py (Diff revision 5)
The issue has been resolved. Show all issues
```
The "subclasses" part should be reworked.
```
reviewboard/hostingsvcs/forgejo/service.py (Diff revision 5)
The issue has been resolved. Show all issues
```
We should escape the repository owner and name.
```

reviewboard/hostingsvcs/tests/test_forgejo.py (Diff revision 5)

The issue has been resolved. Show all issues

To make this a tad less verbose, can we pull out service_class?

Commits:

	Summary	ID
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv
	Add support for Forgejo. Forgejo is a newish open-source code forge system forked from Gitea which has been rapidly gaining popularity. This change adds hosting service support for it. This implementation handles all of the main parts of integration for the hosting service, including: - Authorization with the service, creating a new API token for the user with the correct permissions. - Basic support for getting file content (git blobs). - Post-commit review support, fetching branches, lists of commits, commit data, and diffs. - Bug tracker integration, including linking to issues and showing the bug infobox. - WebHook support for closing review requests when commits are pushed. The only hosting service feature which is not implemented is the remote repository listing. Testing Done: - Tested authorization and API token creation, including when 2FA was enabled. - Verified pre-commit and post-commit review functionality against a self-hosted Forgejo server. - Checked linking to bugs and the bug infobox. - Verified that setting up a WebHook according to the instructions worked correctly, and that pushing code to Forgejo properly closed relevant review requests. - Ran unit tests.	zupounommokpsrpqoprqqltlnnwoyztv

Diff:

Revision 6 (+6146)

Show changes

	reviewboard/dependencies.py
	reviewboard/hostingsvcs/base/registry.py
	reviewboard/hostingsvcs/forgejo/__init__.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/forgejo/errors.py
	reviewboard/hostingsvcs/forgejo/forms.py
	reviewboard/hostingsvcs/forgejo/service.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (7d60ff0)