Summary

Switch away from deprecated django.utils.timezone.utc.

Review Request #14605 — Created Sept. 10, 2025 and submitted Oct. 3, 2025, 8:12 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Once upon a time, Python didn't have good APIs for dealing with time
zones, and Django shipped their own utc helper. That changed, and
django.utils.timezone.utc is scheduled for removal in 5.0 and raises a
warning. This change replaces it with datetime.timezone.utc

Testing Done

Ran unit tests and no longer saw the warning.

Commits

Summary	ID
Switch away from deprecated django.utils.timezone.utc. Once upon a time, Python didn't have good APIs for dealing with time zones, and Django shipped their own utc helper. That changed, and `django.utils.timezone.utc` is scheduled for removal in 5.0 and raises a warning. This change replaces it with `timezone.now()` Testing Done: Ran unit tests and no longer saw the warning.	qrroqpqvtxmmkrwowqlwzkkpvkuzqkom

Issues

Description	From	Last Updated
We have a bunch of different patterns for the two timezones and dealing with their naming conflicts. This change is …	chipx86	Sept. 15, 2025, 9:29 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/reviews/tests/test_review_request_page_data.py (Diff revision 1)

The issue has been resolved. Show all issues

We have a bunch of different patterns for the two timezones and dealing with their naming conflicts. This change is introducing another, and I think it'd be a good time to settle on what we want to do going forward.

The pattern I've been leaning toward is to alias datetime.timezone as tz and keep django.utils.timezone as timezone, which gives us a consistent timezone.now() (which we use a lot) and then tz.utc for that reference.

Description:

		Once upon a time, Python didn't have good APIs for dealing with time
		zones, and Django shipped their own utc helper. That changed, and
		`django.utils.timezone.utc` is scheduled for removal in 5.0 and raises a
~		warning. This change replaces it with `timezone.now()`
	~	warning. This change replaces it with `datetime.timezone.utc`

Commits:

	Summary	ID
	Switch away from deprecated django.utils.timezone.utc. Once upon a time, Python didn't have good APIs for dealing with time zones, and Django shipped their own utc helper. That changed, and `django.utils.timezone.utc` is scheduled for removal in 5.0 and raises a warning. This change replaces it with `timezone.now()` Testing Done: Ran unit tests and no longer saw the warning.	qrroqpqvtxmmkrwowqlwzkkpvkuzqkom
	Switch away from deprecated django.utils.timezone.utc. Once upon a time, Python didn't have good APIs for dealing with time zones, and Django shipped their own utc helper. That changed, and `django.utils.timezone.utc` is scheduled for removal in 5.0 and raises a warning. This change replaces it with `timezone.now()` Testing Done: Ran unit tests and no longer saw the warning.	qrroqpqvtxmmkrwowqlwzkkpvkuzqkom

Diff:

Revision 2 (+4 -4)

Show changes

reviewboard/reviews/tests/test_review_request_page_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (b5d4464)