Deprecate Review Board's assertQueries() method.

Review Request #14603 — Created Sept. 10, 2025 and submitted

Information

Review Board
release-7.1.x

Reviewers

The underlying Djblets TestCase.assertQueries() has had a deprecation
warning, but Review Board didn't. This still triggered warnings, but the
line number associated with those made it harder to find the actual
instances, since it'd just show the call to super().assertQueries().
This change marks the subclass version for deprecation at the matching
version to when we'll be removing the Djblets one.

This also cleans up a little bit of adjacent code that was very out of
date.

Ran unit tests.

Summary ID
Deprecate Review Board's assertQueries() method.
The underlying Djblets TestCase.assertQueries() has had a deprecation warning, but Review Board didn't. This still triggered warnings, but the line number associated with those made it harder to find the actual instances, since it'd just show the call to `super().assertQueries()`. This change marks the subclass version for deprecation at the matching version to when we'll be removing the Djblets one. This also cleans up a little bit of adjacent code that was very out of date. Testing Done: Ran unit tests.
klqqroqmyynvsuwmyoqwxqylpypsnwwt
Description From Last Updated

Looks like this got moved to the wrong place.

maubinmaubin

The warning class says Review Board 9 but this says Review Board 10.

maubinmaubin
david
maubin
  1. 
      
  2. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues

    Looks like this got moved to the wrong place.

  3. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues

    The warning class says Review Board 9 but this says Review Board 10.

  4. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.1.x (3321283)