Summary

Deprecate Review Board's assertQueries() method.

Review Request #14603 — Created Sept. 10, 2025 and submitted Sept. 15, 2025, 4:24 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The underlying Djblets TestCase.assertQueries() has had a deprecation
warning, but Review Board didn't. This still triggered warnings, but the
line number associated with those made it harder to find the actual
instances, since it'd just show the call to super().assertQueries().
This change marks the subclass version for deprecation at the matching
version to when we'll be removing the Djblets one.

This also cleans up a little bit of adjacent code that was very out of
date.

Testing Done

Ran unit tests.

Commits

Summary	ID
Deprecate Review Board's assertQueries() method. The underlying Djblets TestCase.assertQueries() has had a deprecation warning, but Review Board didn't. This still triggered warnings, but the line number associated with those made it harder to find the actual instances, since it'd just show the call to `super().assertQueries()`. This change marks the subclass version for deprecation at the matching version to when we'll be removing the Djblets one. This also cleans up a little bit of adjacent code that was very out of date. Testing Done: Ran unit tests.	klqqroqmyynvsuwmyoqwxqylpypsnwwt

Summary

Deprecate Review Board's assertQueries() method.

The underlying Djblets TestCase.assertQueries() has had a deprecation warning, but Review Board didn't. This still triggered warnings, but the line number associated with those made it harder to find the actual instances, since it'd just show the call to `super().assertQueries()`. This change marks the subclass version for deprecation at the matching version to when we'll be removing the Djblets one. This also cleans up a little bit of adjacent code that was very out of date. Testing Done: Ran unit tests.

klqqroqmyynvsuwmyoqwxqylpypsnwwt

Issues

Description	From	Last Updated
Looks like this got moved to the wrong place.	maubin	Sept. 12, 2025, 3:24 a.m.
The warning class says Review Board 9 but this says Review Board 10.	maubin	Sept. 12, 2025, 3:24 a.m.

flake8 passed.

JSHint passed.

Branch:: master
release-7.1.x

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Looks like this got moved to the wrong place.
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
The warning class says Review Board 9 but this says Review Board 10.
```

Commits:

	Summary	ID
	Deprecate Review Board's assertQueries() method. The underlying Djblets TestCase.assertQueries() has had a deprecation warning, but Review Board didn't. This still triggered warnings, but the line number associated with those made it harder to find the actual instances, since it'd just show the call to `super().assertQueries()`. This change marks the subclass version for deprecation at the matching version to when we'll be removing the Djblets one. This also cleans up a little bit of adjacent code that was very out of date. Testing Done: Ran unit tests.	klqqroqmyynvsuwmyoqwxqylpypsnwwt
	Deprecate Review Board's assertQueries() method. The underlying Djblets TestCase.assertQueries() has had a deprecation warning, but Review Board didn't. This still triggered warnings, but the line number associated with those made it harder to find the actual instances, since it'd just show the call to `super().assertQueries()`. This change marks the subclass version for deprecation at the matching version to when we'll be removing the Djblets one. This also cleans up a little bit of adjacent code that was very out of date. Testing Done: Ran unit tests.	klqqroqmyynvsuwmyoqwxqylpypsnwwt

Diff:

Revision 2 (+52 -48)

Show changes

reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (3321283)