Summary

Add unit tests for our authentication flows.

Review Request #14598 — Created Sept. 8, 2025 and updated Oct. 16, 2025, 12:23 a.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

14580

Reviewers

Groups

rbtools

People

Description

This adds unit tests for our authentication flows (our HTTP auth handlers
andvsession authentication). These flows have recently been updated to
include web-based login, so it's a good time to add unit tests for
these.

There's a TODO note left in here to flesh out the OTP login flow, since
this is too outside of the scope of my web-login changes.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	75773c0491ed458e68238ef1c1f8cc25feca124c

Issues

Description	From	Last Updated
You can use b:'user:pass' instead of encoding. Here and below.	chipx86	Sept. 14, 2025, 11:54 p.m.
Minor nit, but we generally put owner= right after the spy and before the op, so it's better tied to …	chipx86	Sept. 14, 2025, 11:55 p.m.
This could use a Version Added.	chipx86	Sept. 14, 2025, 11:56 p.m.
I believe this needs an owner=.	chipx86	Sept. 14, 2025, 11:58 p.m.
Same here.	chipx86	Sept. 14, 2025, 11:58 p.m.
Same here.	chipx86	Sept. 14, 2025, 11:59 p.m.
Same here. And the ones below.	chipx86	Sept. 14, 2025, 11:59 p.m.
This should be in multi-line form.	chipx86	Sept. 15, 2025, midnight
This also needs owner=.	chipx86	Sept. 15, 2025, midnight
Can we call this _TestCommand? Often having classes with the name Test* will generate warnings about collecting test cases.	david	Sept. 18, 2025, 2:26 a.m.
Test docstrings should all start with "Testing" This applies throughout this entire change.	david	Sept. 22, 2025, 12:14 p.m.
This needs a docstring.	david	Sept. 22, 2025, 12:16 p.m.
Typo: toke -> token	david	Sept. 22, 2025, 12:20 p.m.
Instead of "Hit" perhaps we can use "Get"?	david	Sept. 22, 2025, 12:21 p.m.
This should use (list[str] \| None) = None	david	Sept. 22, 2025, 12:23 p.m.
Actually, just one note. This can be: args=[*command_args, '--debug']	david	Sept. 25, 2025, 4:14 a.m.
Let's update to 5.4 for this release. Here and elsewhere.	chipx86	Oct. 15, 2025, 11:49 p.m.
This should be assertSpyLastRaised, for consistency.	chipx86	Oct. 15, 2025, 11:50 p.m.
Here, too.	chipx86	Oct. 15, 2025, 11:50 p.m.

flake8 passed.

JSHint passed.

rbtools/api/tests/test_auth_handlers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
You can use b:'user:pass' instead of encoding.
Here and below.
```

rbtools/api/tests/test_auth_handlers.py (Diff revision 1)

The issue has been resolved. Show all issues

Minor nit, but we generally put owner= right after the spy and before the op, so it's better tied to the thing we're spying on. Here and below.

rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This could use a Version Added.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I believe this needs an owner=.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
And the ones below.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be in multi-line form.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This also needs owner=.
```

Commits:

	Summary	ID
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	2eb007c6e69e6c437fb0a899e0e83170e08ab651
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	bba819e5de8c103c84b760eaab905092b5181c24

Diff:

Revision 2 (+1478)

Show changes

	rbtools/api/tests/test_auth_handlers.py
	rbtools/commands/tests/test_command_auth_session.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/tests/test_auth_handlers.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we call this _TestCommand? Often having classes with the name Test* will generate warnings about collecting test cases.

Commits:

	Summary	ID
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	bba819e5de8c103c84b760eaab905092b5181c24
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	a69c78e47ca3bbd62337b42186b4db5f662c45ae

Diff:

Revision 3 (+1478)

Show changes

	rbtools/api/tests/test_auth_handlers.py
	rbtools/commands/tests/test_command_auth_session.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/tests/test_auth_handlers.py (Diff revision 3)

The issue has been resolved. Show all issues

Test docstrings should all start with "Testing"

This applies throughout this entire change.

rbtools/api/tests/test_auth_handlers.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This needs a docstring.
```
rbtools/api/tests/test_auth_handlers.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Typo: toke -> token
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Instead of "Hit" perhaps we can use "Get"?
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should use (list[str] | None) = None
```

Commits:

	Summary	ID
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	a69c78e47ca3bbd62337b42186b4db5f662c45ae
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	e5b4f8e70f3a0baf77f84a6058d2094b8b502e3d

Diff:

Revision 4 (+1480)

Show changes

	rbtools/api/tests/test_auth_handlers.py
	rbtools/commands/tests/test_command_auth_session.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/commands/tests/test_command_auth_session.py (Diff revision 4)

The issue has been resolved. Show all issues

Actually, just one note. This can be:
args=[*command_args, '--debug']

maubin Sept. 25, 2025, 4:33 a.m.

Ah this is leftover debug code, and I meant to only pass --debug for one test. I'll move it instead.

Commits:

	Summary	ID
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	e5b4f8e70f3a0baf77f84a6058d2094b8b502e3d
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	3cf2f8915595907a3bf5147ec4809cd39bb5574e

Diff:

Revision 5 (+1486)

Show changes

	rbtools/api/tests/test_auth_handlers.py
	rbtools/commands/tests/test_command_auth_session.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/api/tests/test_auth_handlers.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Let's update to 5.4 for this release. Here and elsewhere.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This should be assertSpyLastRaised, for consistency.
```
rbtools/commands/tests/test_command_auth_session.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Here, too.
```

Commits:

	Summary	ID
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	3cf2f8915595907a3bf5147ec4809cd39bb5574e
	Add unit tests for our authentication flows. This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.	75773c0491ed458e68238ef1c1f8cc25feca124c

Diff:

Revision 6 (+1486)

Show changes

	rbtools/api/tests/test_auth_handlers.py
	rbtools/commands/tests/test_command_auth_session.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.