Add unit tests for our authentication flows.
Review Request #14598 — Created Sept. 8, 2025 and updated
This adds unit tests for our authentication flows (our HTTP auth handlers andvsession authentication). These flows have recently been updated to include web-based login, so it's a good time to add unit tests for these. There's a TODO note left in here to flesh out the OTP login flow, since this is too outside of the scope of my web-login changes.
Ran unit tests.
Summary | ID |
---|---|
3cf2f8915595907a3bf5147ec4809cd39bb5574e |
Description | From | Last Updated |
---|---|---|
You can use b:'user:pass' instead of encoding. Here and below. |
|
|
Minor nit, but we generally put owner= right after the spy and before the op, so it's better tied to … |
|
|
This could use a Version Added. |
|
|
I believe this needs an owner=. |
|
|
Same here. |
|
|
Same here. |
|
|
Same here. And the ones below. |
|
|
This should be in multi-line form. |
|
|
This also needs owner=. |
|
|
Can we call this _TestCommand? Often having classes with the name Test* will generate warnings about collecting test cases. |
|
|
Test docstrings should all start with "Testing" This applies throughout this entire change. |
|
|
This needs a docstring. |
|
|
Typo: toke -> token |
|
|
Instead of "Hit" perhaps we can use "Get"? |
|
|
This should use (list[str] | None) = None |
|
|
Actually, just one note. This can be: args=[*command_args, '--debug'] |
|

- Commits:
-
Summary ID 2eb007c6e69e6c437fb0a899e0e83170e08ab651 bba819e5de8c103c84b760eaab905092b5181c24
Checks run (2 succeeded)

- Commits:
-
Summary ID bba819e5de8c103c84b760eaab905092b5181c24 a69c78e47ca3bbd62337b42186b4db5f662c45ae
Checks run (2 succeeded)

- Commits:
-
Summary ID a69c78e47ca3bbd62337b42186b4db5f662c45ae e5b4f8e70f3a0baf77f84a6058d2094b8b502e3d