flake8
passed.
JSHint
passed.
Review Request #14596 — Created Sept. 6, 2025 and updated
This fleshes out the remainder of reviewboard.diffviewer.commit_utils
with typing and documentation. The validation payloads are now fully
typed, which is only useful internally as this is considered opaque
outside this module.There is one fix with equality checking for CommitHistoryDiffEntry. It
assumed the other type, and would crash if given a different type. We
now check for this.This is mostly the same as Christian's change at /r/14416. The changes
I've made:
SerializedCommitHistoryDiffEntryType
so it's defined beforeDiffCommitsValidationInfo
docs.str
or dict
.Ran unit tests.
Summary | ID |
---|---|
wwzyusmmzuyvvuqrtkzrznuwnklmwtno |