Summary

Modernize hosting service test class.

Review Request #14592 — Created Sept. 4, 2025 and updated Sept. 4, 2025, 9 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

People

Description

The hosting service specific testcase class provides some neat

utilities, but very little of it had any type hints. This change fleshes

those out, and fixes up a couple issues with some types in the base

hosting service that this exposed. Subclasses of this have been updated

for the new generic.

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize hosting service test class. The hosting service specific testcase class provides some neat utilities, but very little of it had any type hints. This change fleshes those out, and fixes up a couple issues with some types in the base hosting service that this exposed. Subclasses of this have been updated for the new generic. Testing Done: Ran unit tests.	pxqtwpvtwtupuropzrunmrwrlnzlyxtv

Issues

Description	From	Last Updated
Literal can go in TYPE_CHECKING.	chipx86	Sept. 4, 2025, 7:37 p.m.
We should just import the type we need, but within a TYPE_CHECKING.	chipx86	Sept. 4, 2025, 7:37 p.m.
This should also go in TYPE_CHECKING.	chipx86	Sept. 4, 2025, 7:37 p.m.
This can also go in TYPE_CHECKING.	chipx86	Sept. 4, 2025, 7:42 p.m.
This is in the wrong import group.	chipx86	Sept. 4, 2025, 7:38 p.m.
This is missing docs with a Version Added.	chipx86	Sept. 4, 2025, 7:39 p.m.
Missing the "Instance variables" block.	chipx86	Sept. 4, 2025, 7:39 p.m.
We have a couple of these. Maybe we should TypeAlias it? Or Protocol it, make it match the argument signature …	chipx86	Sept. 4, 2025, 8:59 p.m.
For all these, can we move the ) to the following line so the strings are isolated? More like we …	chipx86	Sept. 4, 2025, 7:40 p.m.
While here, can we convert to keyword arguments?	chipx86	Sept. 4, 2025, 7:42 p.m.
Existing code, but these should not be , optional.	chipx86	Sept. 4, 2025, 7:43 p.m.
Missing a return type.	chipx86	Sept. 4, 2025, 7:43 p.m.
Existing code, but these should not be , optional.	chipx86	Sept. 4, 2025, 7:43 p.m.
Existing code, but these should not be , optional.	chipx86	Sept. 4, 2025, 7:43 p.m.
This should be , optional.	chipx86	Sept. 4, 2025, 8:52 p.m.
These should be , optional.	chipx86	Sept. 4, 2025, 8:52 p.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Literal can go in TYPE_CHECKING.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should just import the type we need, but within a TYPE_CHECKING.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should also go in TYPE_CHECKING.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can also go in TYPE_CHECKING.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is in the wrong import group.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is missing docs with a Version Added.
```
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing the "Instance variables" block.
```

reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)

The issue has been resolved. Show all issues

We have a couple of these. Maybe we should TypeAlias it? Or Protocol it, make it match the argument signature so we gain typing there?

reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)

The issue has been resolved. Show all issues

For all these, can we move the ) to the following line so the strings are isolated? More like we do with dicts and lists.

reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)

The issue has been resolved. Show all issues

While here, can we convert to keyword arguments?

reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 1)

The issue has been resolved. Show all issues

Existing code, but these should not be , optional.

reviewboard/hostingsvcs/tests/test_beanstalk.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a return type.
```

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)

The issue has been resolved. Show all issues

Existing code, but these should not be , optional.

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)

The issue has been resolved. Show all issues

Existing code, but these should not be , optional.

reviewboard/hostingsvcs/tests/test_github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be , optional.
```

reviewboard/hostingsvcs/tests/test_rbgateway.py (Diff revision 1)

The issue has been resolved. Show all issues

These should be , optional.

Commits:

	Summary	ID
	Modernize hosting service test class. The hosting service specific testcase class provides some neat utilities, but very little of it had any type hints. This change fleshes those out, and fixes up a couple issues with some types in the base hosting service that this exposed. Subclasses of this have been updated for the new generic. Testing Done: Ran unit tests.	pxqtwpvtwtupuropzrunmrwrlnzlyxtv
	Modernize hosting service test class. The hosting service specific testcase class provides some neat utilities, but very little of it had any type hints. This change fleshes those out, and fixes up a couple issues with some types in the base hosting service that this exposed. Subclasses of this have been updated for the new generic. Testing Done: Ran unit tests.	pxqtwpvtwtupuropzrunmrwrlnzlyxtv

Diff:

Revision 2 (+1932 -1152)

	reviewboard/hostingsvcs/testing/testcases.py
	reviewboard/hostingsvcs/tests/test_assembla.py
	reviewboard/hostingsvcs/tests/test_beanstalk.py
	reviewboard/hostingsvcs/tests/test_bitbucket.py
	reviewboard/hostingsvcs/tests/test_bugzilla.py
	reviewboard/hostingsvcs/tests/test_codebasehq.py
	reviewboard/hostingsvcs/tests/test_fogbugz.py
	reviewboard/hostingsvcs/tests/test_gerrit.py
	10 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.