Summary

Modernize reviewboard.hostingsvcs.hook_utils.

Review Request #14590 — Created Sept. 4, 2025 and updated Sept. 4, 2025, 9:18 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds type hints and modernizes documentation within the
hook_utils module.

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize reviewboard.hostingsvcs.hook_utils. This change adds type hints and modernizes documentation within the `hook_utils` module. Testing Done: Ran unit tests.	qxxlxyxqquvsynqqtuwqlxrxtnzvmkxx

Issues

Description	From	Last Updated
"Git"	chipx86	Sept. 4, 2025, 9:15 p.m.
Doesn't have to be this change, but we should probably make all these take keyword-only arguments, given the complexity and …	chipx86	Sept. 4, 2025, 9:15 p.m.
'threading.local' imported but unused Column: 1 Error code: F401	reviewbot	Sept. 4, 2025, 9:18 p.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/hook_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Git"
```

reviewboard/hostingsvcs/hook_utils.py (Diff revision 1)

The issue has been resolved. Show all issues

Doesn't have to be this change, but we should probably make all these take keyword-only arguments, given the complexity and probably need for future expansion here.

Commits:

	Summary	ID
	Modernize reviewboard.hostingsvcs.hook_utils. This change adds type hints and modernizes documentation within the `hook_utils` module. Testing Done: Ran unit tests.	qxxlxyxqquvsynqqtuwqlxrxtnzvmkxx
	Modernize reviewboard.hostingsvcs.hook_utils. This change adds type hints and modernizes documentation within the `hook_utils` module. Testing Done: Ran unit tests.	qxxlxyxqquvsynqqtuwqlxrxtnzvmkxx

Diff:

Revision 2 (+436 -118)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/hook_utils.py
	reviewboard/hostingsvcs/rbgateway.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'threading.local' imported but unused

Column: 1
Error code: F401
```

Commits:

	Summary	ID
	Modernize reviewboard.hostingsvcs.hook_utils. This change adds type hints and modernizes documentation within the `hook_utils` module. Testing Done: Ran unit tests.	qxxlxyxqquvsynqqtuwqlxrxtnzvmkxx
	Modernize reviewboard.hostingsvcs.hook_utils. This change adds type hints and modernizes documentation within the `hook_utils` module. Testing Done: Ran unit tests.	qxxlxyxqquvsynqqtuwqlxrxtnzvmkxx

Diff:

Revision 3 (+434 -118)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/hook_utils.py
	reviewboard/hostingsvcs/rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.