Summary

Get rid of deprecated hosting services code.

Review Request #14589 — Created Sept. 4, 2025 and submitted Oct. 7, 2025, 8:05 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The hosting services client and HTTP interface had a few things which we
had deprecated for removal in RB8, primarily related to JSON. The
bugzilla and splat implementations used these, but those were the only
ones. This change updates those implementations to use rsp.json
instead of the json_* methods, and then removes the deprecated code.

Testing Done

Ran unit tests.

Commits

Summary	ID
Get rid of deprecated hosting services code. The hosting services client and HTTP interface had a few things which we had deprecated for removal in RB8, primarily related to JSON. The bugzilla and splat implementations used these, but those were the only ones. This change updates those implementations to use `rsp.json` instead of the `json_*` methods, and then removes the deprecated code. Testing Done: Ran unit tests.	vktyqnkwtlwtpoonmyvqpkvoponqlznt

Summary

Get rid of deprecated hosting services code.

The hosting services client and HTTP interface had a few things which we had deprecated for removal in RB8, primarily related to JSON. The bugzilla and splat implementations used these, but those were the only ones. This change updates those implementations to use `rsp.json` instead of the `json_*` methods, and then removes the deprecated code. Testing Done: Ran unit tests.

vktyqnkwtlwtpoonmyvqpkvoponqlznt

Issues

Description	From	Last Updated
'collections.abc.Mapping' imported but unused Column: 5 Error code: F401	reviewbot	Sept. 4, 2025, 12:11 p.m.
redefinition of unused 'Repository' from line 17 Column: 5 Error code: F811	reviewbot	Sept. 4, 2025, 12:11 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/splat.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'collections.abc.Mapping' imported but unused

Column: 5
Error code: F401
```
reviewboard/hostingsvcs/splat.py (Diff revision 1)
The issue has been dropped. Show all issues
```
redefinition of unused 'Repository' from line 17

Column: 5
Error code: F811
```

Commits:

	Summary	ID
	Get rid of deprecated hosting services code. The hosting services client and HTTP interface had a few things which we had deprecated for removal in RB8, primarily related to JSON. The bugzilla and splat implementations used these, but those were the only ones. This change updates those implementations to use `rsp.json` instead of the `json_*` methods, and then removes the deprecated code. Testing Done: Ran unit tests.	vktyqnkwtlwtpoonmyvqpkvoponqlznt
	Get rid of deprecated hosting services code. The hosting services client and HTTP interface had a few things which we had deprecated for removal in RB8, primarily related to JSON. The bugzilla and splat implementations used these, but those were the only ones. This change updates those implementations to use `rsp.json` instead of the `json_*` methods, and then removes the deprecated code. Testing Done: Ran unit tests.	vktyqnkwtlwtpoonmyvqpkvoponqlznt

Diff:

Revision 2 (+40 -1390)

Show changes

	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/splat.py
	reviewboard/hostingsvcs/base/client.py
	reviewboard/hostingsvcs/base/http.py
	reviewboard/hostingsvcs/tests/test_client.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ee48c50)