Summary

Move BugTracker into reviewboard.hostingsvcs.base.

Review Request #14586 — Created Sept. 4, 2025 and submitted Oct. 6, 2025, 7:46 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The rest of our base classes have all been moved into the
reviewboard.hostingsvcs.base module, but the bug tracker interface was
still in the top-level directory. This change moves it and updates
the services which use it to use the new import.

Testing Done

Ran unit tests.

Commits

Summary	ID
Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl

Issues

Description	From	Last Updated
Can we name this BaseBugTracker?	chipx86	Sept. 4, 2025, 7:27 p.m.
This needs version information stating it moved.	chipx86	Sept. 4, 2025, 7:28 p.m.
Missing the Instance Variables block and a comment.	chipx86	Sept. 4, 2025, 7:28 p.m.
We can probably say a BugInfo dictionary (linking to the class).	chipx86	Sept. 4, 2025, 7:28 p.m.
I know this is old code, but this comment feels a bit out of place these days. Maybe worth a …	chipx86	Sept. 4, 2025, 7:29 p.m.
We should switch to the new pathed keys in Djblets, since there's user input (bug IDs) in here.	chipx86	Sept. 4, 2025, 7:34 p.m.
TYPE_CHECKING sorts first.	chipx86	Sept. 15, 2025, 9:35 a.m.
Do we want to make this a Literal[...]?	chipx86	Sept. 15, 2025, 9:35 a.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we name this BaseBugTracker?
```
reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs version information stating it moved.
```
reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing the Instance Variables block and a comment.
```
reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We can probably say a BugInfo dictionary (linking to the class).
```

reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)

The issue has been resolved. Show all issues

I know this is old code, but this comment feels a bit out of place these days. Maybe worth a revisit.

reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 1)

The issue has been resolved. Show all issues

We should switch to the new pathed keys in Djblets, since there's user input (bug IDs) in here.

Commits:

	Summary	ID
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import.	npzkpwumqtkyyyyxovlstolxkwozkwpr
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	npzkpwumqtkyyyyxovlstolxkwozkwpr

Diff:

Revision 2 (+574 -166)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/jira.py
	reviewboard/hostingsvcs/splat.py
	reviewboard/hostingsvcs/base/__init__.py
	reviewboard/hostingsvcs/base/bug_tracker.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Move to release-7.1.x

Commits:

	Summary	ID
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	npzkpwumqtkyyyyxovlstolxkwozkwpr
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl

Branch:

master

release-7.1.x

Diff:

Revision 3 (+574 -166)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/jira.py
	reviewboard/hostingsvcs/splat.py
	reviewboard/hostingsvcs/base/__init__.py
	reviewboard/hostingsvcs/base/bug_tracker.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fix version comments.

Commits:

	Summary	ID
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl

Diff:

Revision 4 (+574 -166)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/jira.py
	reviewboard/hostingsvcs/splat.py
	reviewboard/hostingsvcs/base/__init__.py
	reviewboard/hostingsvcs/base/bug_tracker.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 4)
The issue has been resolved. Show all issues
```
TYPE_CHECKING sorts first.
```
reviewboard/hostingsvcs/base/bug_tracker.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Do we want to make this a Literal[...]?
```

Commits:

	Summary	ID
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl
	Move BugTracker into reviewboard.hostingsvcs.base. The rest of our base classes have all been moved into the `reviewboard.hostingsvcs.base` module, but the bug tracker interface was still in the top-level directory. This change moves it and updates the services which use it to use the new import. Testing Done: Ran unit tests.	towzyqzmzvrqryzottmxpryxqrnznnzl

Diff:

Revision 5 (+570 -166)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/hostingsvcs/bugtracker.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/jira.py
	reviewboard/hostingsvcs/splat.py
	reviewboard/hostingsvcs/base/__init__.py
	reviewboard/hostingsvcs/base/bug_tracker.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (29aad66)