Summary

Add formal deprecation notices to reviewboard.hostingsvcs.forms.

Review Request #14585 — Created Sept. 4, 2025 and updated Sept. 4, 2025, 1:56 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A while ago, we moved most of the actual base hosting service forms into
reviewboard.hostingsvcs.base.forms. The old
reviewboard.hostingsvcs.forms module had forwarding imports and a
comment about deprecation, but we didn't have any actual deprecation
warnings. This adds deprecation warnings for everything in that module,
and updates dependent code to use the new names.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add formal deprecation notices to reviewboard.hostingsvcs.forms. A while ago, we moved most of the actual base hosting service forms into `reviewboard.hostingsvcs.base.forms`. The old `reviewboard.hostingsvcs.forms` module had forwarding imports and a comment about deprecation, but we didn't have any actual deprecation warnings. This adds deprecation warnings for everything in that module, and updates dependent code to use the new names. Testing Done: - Ran unit tests.	pulmwsynmmtomwyyrswmryspplllrxtx

Summary

Add formal deprecation notices to reviewboard.hostingsvcs.forms.

A while ago, we moved most of the actual base hosting service forms into `reviewboard.hostingsvcs.base.forms`. The old `reviewboard.hostingsvcs.forms` module had forwarding imports and a comment about deprecation, but we didn't have any actual deprecation warnings. This adds deprecation warnings for everything in that module, and updates dependent code to use the new names. Testing Done: - Ran unit tests.

pulmwsynmmtomwyyrswmryspplllrxtx

Issues

Description	From	Last Updated
line too long (83 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 4, 2025, 10:57 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_hosting_service_auth_form.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (83 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add formal deprecation notices to reviewboard.hostingsvcs.forms. A while ago, we moved most of the actual base hosting service forms into `reviewboard.hostingsvcs.base.forms`. The old `reviewboard.hostingsvcs.forms` module had forwarding imports and a comment about deprecation, but we didn't have any actual deprecation warnings. This adds deprecation warnings for everything in that module, and updates dependent code to use the new names. Testing Done: - Ran unit tests.	pulmwsynmmtomwyyrswmryspplllrxtx
	Add formal deprecation notices to reviewboard.hostingsvcs.forms. A while ago, we moved most of the actual base hosting service forms into `reviewboard.hostingsvcs.base.forms`. The old `reviewboard.hostingsvcs.forms` module had forwarding imports and a comment about deprecation, but we didn't have any actual deprecation warnings. This adds deprecation warnings for everything in that module, and updates dependent code to use the new names. Testing Done: - Ran unit tests.	pulmwsynmmtomwyyrswmryspplllrxtx

Diff:

Revision 2 (+344 -228)

Show changes

	reviewboard/hostingsvcs/assembla.py
	reviewboard/hostingsvcs/beanstalk.py
	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/codebasehq.py
	reviewboard/hostingsvcs/fedorahosted.py
	reviewboard/hostingsvcs/fogbugz.py
	reviewboard/hostingsvcs/forms.py
	17 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```