Summary

Switch to getting appdirs from pypi.

Review Request #14577 — Created Aug. 28, 2025 and updated Sept. 4, 2025, 5:24 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

When we first added appdirs to RBTools, we vendored the file into our
tree because they were not providing builds on PyPI. This changed a long
time ago, so there's no good reason for us to continue to ship our own,
outdated copy.

Testing Done

Ran unit tests.

Commits

Summary	ID
Switch to getting appdirs from pypi. When we first added `appdirs` to RBTools, we vendored the file into our tree because they were not providing builds on PyPI. This changed a long time ago, so there's no good reason for us to continue to ship our own, outdated copy. Testing Done: Ran unit tests.	prolqzsvvqqyxlyurmwkrllxoptzqpvk

Issues

Description	From	Last Updated
I know they haven't changed it in a while, but we've been bitten too many times lately by a breaking …	chipx86	Sept. 4, 2025, 5:24 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

pyproject.toml (Diff revision 1)

The issue has been resolved. Show all issues

I know they haven't changed it in a while, but we've been bitten too many times lately by a breaking version change. We should tie this to a version range. ~=1.4.4 is probably safer.

Commits:

	Summary	ID
	Switch to getting appdirs from pypi. When we first added `appdirs` to RBTools, we vendored the file into our tree because they were not providing builds on PyPI. This changed a long time ago, so there's no good reason for us to continue to ship our own, outdated copy. Testing Done: Ran unit tests.	prolqzsvvqqyxlyurmwkrllxoptzqpvk
	Switch to getting appdirs from pypi. When we first added `appdirs` to RBTools, we vendored the file into our tree because they were not providing builds on PyPI. This changed a long time ago, so there's no good reason for us to continue to ship our own, outdated copy. Testing Done: Ran unit tests.	prolqzsvvqqyxlyurmwkrllxoptzqpvk

Diff:

Revision 2 (+14 -1164)

Show changes

	pyproject.toml
	setup.cfg
	rbtools/api/cache.py
	rbtools/clients/tfs.py
	rbtools/commands/install.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.