Summary

Allow all rbt commands to authenticate using web-based login.

Review Request #14576 — Created Sept. 8, 2025 and updated Dec. 4, 2025, 9:39 p.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

14575

Reviewers

Groups

rbtools

People

Description

This is the final change in a series of changes that ultimately allow

using web-based login for authentication in any rbt command.
We pass a web login callback function through to the

ReviewBoardHTTPPasswordMgr where our other auth callbacks live. We

also add a ReviewBoardWebLoginHandler auth handler which attempts

web-based login once upon the first HTTP 401. If it fails, we fall back

on our existing handlers.

Testing Done


Tested rbt post and rbt status passing --web-login to log in to

  a local dev server.
Tested  rbt post and rbt status passing --web-login to log in to

  the real https://reviews.reviewboard.org server.
In the above tests, made sure that the ReviewBoardWebLoginHandler

  auth handler logic was reached by rbt post, and the

get_authenticated_session logic was reached by rbt status.
Tested on RB6 and RB7.1.
Ran unit tests and add unit tests in an upcoming change.

Commits

Summary	ID
Allow all rbt commands to authenticate using web-based login. This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.	a386d7e788ee684b3a6c58c9d7465e413859d518

Summary

Allow all rbt commands to authenticate using web-based login.

This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.

a386d7e788ee684b3a6c58c9d7465e413859d518

Issues

Description	From	Last Updated
Can you add docs and a "Version Added" for this?	chipx86	Sept. 14, 2025, 11:26 p.m.
Let's put two blank lines on either side.	david	Sept. 22, 2025, 12:04 p.m.
This should include a "Version Changed" with the new argument.	chipx86	Sept. 14, 2025, 11:27 p.m.
The description shouldn't be indented.	chipx86	Sept. 14, 2025, 11:28 p.m.
Is this to address a circular import? If so, can you add a comment for that?	chipx86	Sept. 14, 2025, 11:31 p.m.
Blank line after the class docstring.	chipx86	Sept. 14, 2025, 11:38 p.m.
This can be HTTPResponse \| None now.	chipx86	Sept. 14, 2025, 11:39 p.m.
Same here.	chipx86	Sept. 14, 2025, 11:39 p.m.
This can be (WebLoginCallback \| None) = None.	chipx86	Sept. 14, 2025, 11:43 p.m.
Can you also add this to a "Version Changed" on the method?	chipx86	Sept. 14, 2025, 11:42 p.m.
Same comment re: \| None.	chipx86	Sept. 14, 2025, 11:44 p.m.
Same comment re: "Version Changed" on the method.	chipx86	Sept. 14, 2025, 11:44 p.m.
Description should be indented one level.	chipx86	Sept. 14, 2025, 11:44 p.m.
Let's go with 5.4 for this release.	chipx86	Oct. 15, 2025, 2:52 a.m.
web_login_callback appears last in the argument list.	chipx86	Oct. 15, 2025, 2:53 a.m.

flake8 passed.

JSHint passed.

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add docs and a "Version Added" for this?
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should include a "Version Changed" with the new argument.
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
The description shouldn't be indented.
```

rbtools/api/request.py (Diff revision 1)

The issue has been resolved. Show all issues

Is this to address a circular import? If so, can you add a comment for that?

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line after the class docstring.
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be HTTPResponse | None now.
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be (WebLoginCallback | None) = None.
```

rbtools/api/request.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you also add this to a "Version Changed" on the method?

rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same comment re: | None.
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same comment re: "Version Changed" on the method.
```
rbtools/commands/base/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Description should be indented one level.
```

Change Summary:

Add missing docs and follow modern typing syntax.

Commits:

	Summary	ID
	Allow all rbt commands to authenticate using web-based login. This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.	23bc2928db6b06360cc3f23cd7b5f84e386f91f2
	Allow all rbt commands to authenticate using web-based login. This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.	70ced093ce0d19bf9d6e892e1f898696243a6edd

Diff:

Revision 2 (+344 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/base/commands.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/api/request.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

Let's put two blank lines on either side.

rbtools/api/request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's go with 5.4 for this release.
```

rbtools/api/request.py (Diff revision 2)

The issue has been resolved. Show all issues

web_login_callback appears last in the argument list.

Commits:

	Summary	ID
	Allow all rbt commands to authenticate using web-based login. This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.	70ced093ce0d19bf9d6e892e1f898696243a6edd
	Allow all rbt commands to authenticate using web-based login. This is the final change in a series of changes that ultimately allow using web-based login for authentication in any rbt command. We pass a web login callback function through to the `ReviewBoardHTTPPasswordMgr` where our other auth callbacks live. We also add a `ReviewBoardWebLoginHandler` auth handler which attempts web-based login once upon the first HTTP 401. If it fails, we fall back on our existing handlers.	a386d7e788ee684b3a6c58c9d7465e413859d518

Diff:

Revision 3 (+348 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/base/commands.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```