Summary

Fix posting jujutsu changes that include deleted files.

Review Request #14563 — Created Aug. 19, 2025 and submitted Aug. 21, 2025, 8:08 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The jujutsu backend for rbtools gets the git diff and then processes it
in order to turn short blob hashes into full hashes. This was broken for
deleted files in two ways:

The regex that parsed index lines didn't catch deleted lines, because
they didn't have any mode information.
Trying to turn '00000000' into a full hash would fail because that
hash doesn't actually exist in the repo.

This change fixes those two issues and adds a test to verify it.

This also fixes a test for an updated message in jj.

Testing Done


Ran unit tests.
Posted a change that included a deleted file.

Commits

Summary	ID
Fix posting jujutsu changes that include deleted files. The jujutsu backend for rbtools gets the git diff and then processes it in order to turn short blob hashes into full hashes. This was broken for deleted files in two ways: - The regex that parsed index lines didn't catch deleted lines, because they didn't have any mode information. - Trying to turn '00000000' into a full hash would fail because that hash doesn't actually exist in the repo. This change fixes those two issues and adds a test to verify it. Testing Done: - Ran unit tests. - Posted a change that included a deleted file.	pupqoxklzltwskylnzulvspvtpyzprlk

Summary

Fix posting jujutsu changes that include deleted files.

The jujutsu backend for rbtools gets the git diff and then processes it in order to turn short blob hashes into full hashes. This was broken for deleted files in two ways: - The regex that parsed index lines didn't catch deleted lines, because they didn't have any mode information. - Trying to turn '00000000' into a full hash would fail because that hash doesn't actually exist in the repo. This change fixes those two issues and adds a test to verify it. Testing Done: - Ran unit tests. - Posted a change that included a deleted file.

pupqoxklzltwskylnzulvspvtpyzprlk

Issues

Description	From	Last Updated
Actually, before you commit, can you update the description to use the formal names: "rbtools" -> "RBTools" "git" -> "Git" …	chipx86	Aug. 21, 2025, 7:54 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Actually, before you commit, can you update the description to use the formal names:

"rbtools" -> "RBTools"
"git" -> "Git"
"jujutsu" -> "Jujutsu"

Status:: Completed
Change Summary:: Pushed to master (69be61f)