Summary

Improve rbext create boilerplate, add type hints.

Review Request #14543 — Created July 31, 2025 and submitted Sept. 5, 2025, 12:11 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The boilerplate created by rbext create was a little bit crufty,
having a mix of fake code and real. This change cleans that up so that
it's true boilerplate only, and all the fake stuff is in comments.

This change also modernizes the implementation of rbext with type
hints and some modern syntax nicety.

Testing Done

Generated extensions with rbext create.

Commits

Summary	ID
Improve rbext create boilerplate, add type hints. The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.	f16b7b90afcc4f767f3a6c2e624c1b1b5ed59ce7

Summary

Improve rbext create boilerplate, add type hints.

The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.

f16b7b90afcc4f767f3a6c2e624c1b1b5ed59ce7

Issues

Description	From	Last Updated
This differs from the previous implementation. The primary document header is missing the leading row of ====s.	chipx86	Aug. 7, 2025, 11:11 p.m.
We can get rid of the u prefix handling now, just return a repr().	chipx86	Aug. 7, 2025, 11:42 p.m.
While here can you add the "Returns" section in the docs for this.	maubin	Aug. 8, 2025, 4:37 p.m.
We should mention .ts files here too.	maubin	Aug. 8, 2025, 4:38 p.m.

flake8 passed.

JSHint passed.

Very nice cleanup. Just two small things.

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been dropped. Show all issues

This differs from the previous implementation. The primary document header is missing the leading row of ====s.

david Aug. 7, 2025, 11:11 p.m.

That's because it's now creating a README.md instead of a README.rst

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been resolved. Show all issues

We can get rid of the u prefix handling now, just return a repr().

Commits:

	Summary	ID
	Improve rbext create boilerplate, add type hints. The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.	af0a2b1713ad9b12ba9a4b34773034948c5e91bb
	Improve rbext create boilerplate, add type hints. The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.	f3cea3095b1023d7bd23988d5eb589593441a292

Diff:

Revision 2 (+524 -430)

Show changes

reviewboard/cmdline/rbext.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/cmdline/rbext.py (Diff revision 2)
The issue has been resolved. Show all issues
```
While here can you add the "Returns" section in the docs for this.
```
reviewboard/cmdline/rbext.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We should mention .ts files here too.
```

Commits:

	Summary	ID
	Improve rbext create boilerplate, add type hints. The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.	f3cea3095b1023d7bd23988d5eb589593441a292
	Improve rbext create boilerplate, add type hints. The boilerplate created by `rbext create` was a little bit crufty, having a mix of fake code and real. This change cleans that up so that it's true boilerplate only, and all the fake stuff is in comments. This change also modernizes the implementation of `rbext` with type hints and some modern syntax nicety. Testing Done: Generated extensions with `rbext create`.	f16b7b90afcc4f767f3a6c2e624c1b1b5ed59ce7

Diff:

Revision 3 (+536 -434)

Show changes

reviewboard/cmdline/rbext.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (07ea17e)