• 
      

    Bail immediately during rb-site if the Django environment can't load.

    Review Request #14538 — Created July 30, 2025 and submitted

    Information

    Review Board
    release-7.1.x

    Reviewers

    When installing Review Board, a bad dependency or other issue
    initializing Django would result in a breakage that won't be noticed
    until later in the process. This would result in a series of
    installation steps that say ERROR, but continue on until an exception
    was raised.

    We now check for errors here, and immediately quit with a helpful
    message so it doesn't appear that the database was created or other
    steps were taken.

    Hit this while doing some testing and got very confused trying to
    install a site.

    Fixed it with this patch and repeated the failed install. Saw the
    error message instead of a supposed "successful installation"
    followed by traceback.

    Summary ID
    Bail immediately during rb-site if the Django environment can't load.
    When installing Review Board, a bad dependency or other issue initializing Django would result in a breakage that won't be noticed until later in the process. This would result in a series of installation steps that say ERROR, but continue on until an exception was raised. We now check for errors here, and immediately quit with a helpful message so it doesn't appear that the database was created or other steps were taken.
    555c53fe1d438fa4eec15ca172aeb3c77eed3c95
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.1.x (bb3cbc6)