Remove deprecation for passing non-string values to API add_field.

Review Request #14489 — Created June 28, 2025 and submitted — Latest diff uploaded

Information

RBTools
master

Reviewers

The API request add_field method has had a deprecation warning for a
while about passing in values that are not either str or bytes. This
change replaces the warning+cast with an exception.

There were a few places inside RBTools itself that were still hitting
this, all in the post implementation. These have been fixed up to format
the values as strings.

  • Ran unit tests.
  • Audited call sites to verify that we were passing string types
    everywhere.
  • Posted changes, including ones that needed to upload binary files.

Diff Revision 4 (Latest)

orig
1
2
3
4

Commits

First Last Summary ID Author
Remove deprecation for passing non-string values to API add_field.
The API request `add_field` method has had a deprecation warning for a while about passing in values that are not either `str` or `bytes`. This change replaces the warning+cast with an exception. There were a few places inside RBTools itself that were still hitting this, all in the post implementation. These have been fixed up to format the values as strings. Testing Done: - Ran unit tests. - Audited call sites to verify that we were passing string types everywhere. - Posted changes, including ones that needed to upload binary files.
7f16aed79145ff42fa8127f18108abd007bfd679 David Trowbridge
rbtools/api/request.py
rbtools/commands/post.py
Loading...