Remove deprecation for passing non-string values to API add_field.

 






 

 


  Review Request #14489
  —
  Created June 28, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The API request add_field method has had a deprecation warning for a

while about passing in values that are not either str or bytes. This

change replaces the warning+cast with an exception.


There were a few places inside RBTools itself that were still hitting

this, all in the post implementation. These have been fixed up to format

the values as strings.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Audited call sites to verify that we were passing string types
    
  everywhere.
    • 

  • Posted changes, including ones that needed to upload binary files.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Remove deprecation for passing non-string values to API add_field.
     
The API request `add_field` method has had a deprecation warning for a
while about passing in values that are not either `str` or `bytes`. This
change replaces the warning+cast with an exception.

There were a few places inside RBTools itself that were still hitting
this, all in the post implementation. These have been fixed up to format
the values as strings.

Testing Done:
- Ran unit tests.
- Audited call sites to verify that we were passing string types
  everywhere.
- Did some smoke testing of posting changes.

    

   
  		
  9c67b0acd147822e9d888e45e2fc5f7be93187a7
  David Trowbridge
 


 
  
 
 
  
   
    

     Remove deprecation for passing non-string values to API add_field.
     
The API request `add_field` method has had a deprecation warning for a
while about passing in values that are not either `str` or `bytes`. This
change replaces the warning+cast with an exception.

There were a few places inside RBTools itself that were still hitting
this, all in the post implementation. These have been fixed up to format
the values as strings.

Testing Done:
- Ran unit tests.
- Audited call sites to verify that we were passing string types
  everywhere.
- Posted changes, including ones that needed to upload binary files.

    

   
  		
  dd4e668a91ea3a9f59ce3132c9b0c6b03984be46
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/api/request.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/post.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...