• 
      

    Officially deprecate execute().

    Review Request #14486 — Created June 27, 2025 and submitted

    Information

    RBTools
    master

    Reviewers

    The rbtools.utils.process.execute() function has theoretically been
    deprecated for several releases, but the actual warning was hidden
    behind an environment variable. Now that we've updated all our code
    inside RBTools itself, this change removes the environment variable and
    changes the deprecation warning to be RemovedInRBTools80Warning.

    Ran unit tests and didn't get any warnings.

    Summary ID
    Officially deprecate execute().
    The rbtools.utils.process.execute() function has theoretically been deprecated for several releases, but the actual warning was hidden behind an environment variable. Now that we've updated all our code inside RBTools itself, this change removes the environment variable and changes the deprecation warning to be `RemovedInRBTools80Warning`. Testing Done: Ran unit tests and didn't get any warnings.
    2d7a7478311015e5d23f9870a42ea8e12c3220bf
    Description From Last Updated

    We can use self.assertRaisesMessage().

    chipx86chipx86
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. 
        
    2. rbtools/utils/tests/test_process.py (Diff revision 1)
       
       
       
       
       
       
       
       
      Show all issues

      We can use self.assertRaisesMessage().

      1. Not for warnings.

      2. Ah, I read that wrong.

    3. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (83630b4)