Port Perforce backend to use run_process() instead of execute()

 






 

 


  Review Request #14484
  —
  Created June 27, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
This change updates the Perforce client to use run_process() instead

of execute(). In order to simplify the implementation here, I've added

new input_string and timeout parameters to run_process and

friends, which allows passing in data to send to the command's standard

input stream.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Port Perforce backend to use run_process() instead of execute()
     
This change updates the Perforce client to use `run_process()` instead
of `execute()`. In order to simplify the implementation here, I've added
a new `input_string` parameter to `run_process` and friends, which
allows passing in data to send to the command's standard input stream.

Testing Done:
Ran unit tests.

    

   
  		
  055362e7605e83460438ccd8c71c5e0198033f72
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/perforce.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_p4.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/utils/process.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...