Summary

Port Mercurial backend to use run_process() instead of execute().

Review Request #14483 — Created June 27, 2025 and submitted Aug. 7, 2025, 8:38 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change updates the Mercurial implementation to use run_process()

instead of execute().

Testing Done

Ran unit tests.

Commits

Summary	ID
Port Mercurial backend to use run_process() instead of execute(). This change updates the Mercurial implementation to use `run_process()` instead of `execute()`. Testing Done: Ran unit tests.	0c53b04a96a0cac5fa77ed196adbc9b0f3f26a35

Issues

Description	From	Last Updated
Probably worth just catching the exception in this case.	chipx86	June 28, 2025, 4:09 p.m.
Probably better to do a try/except instead of ignoring and then checking.	chipx86	June 28, 2025, 4:11 p.m.
We should be localizing these strings.	chipx86	June 28, 2025, 4:11 p.m.
No need for the else: here.	chipx86	June 28, 2025, 4:12 p.m.
Two different import groups.	chipx86	June 28, 2025, 4:13 p.m.
These are missing docs.	chipx86	June 28, 2025, 4:15 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably worth just catching the exception in this case.
```

rbtools/clients/mercurial.py (Diff revision 1)

The issue has been resolved. Show all issues

Probably better to do a try/except instead of ignoring and then checking.

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should be localizing these strings.
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No need for the else: here.
```
rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Two different import groups.
```

rbtools/utils/process.py (Diff revision 1)

The issue has been dropped. Show all issues

These are missing docs.

david June 28, 2025, 4:51 p.m.

These are all just mirrors of what's immediately below inside the run_process method, and it's just used to have type checking for methods that wrap run_process, like MercurialClient._execute. I don't feel like it makes any sense to copy/paste all the documentation for something like that.

Commits:

	Summary	ID
	Port Mercurial backend to use run_process() instead of execute(). This change updates the Mercurial implementation to use `run_process()` instead of `execute()`. Testing Done: Ran unit tests.	5503801b8f7a70df61b9b15499e6c253b26ccb3f
	Port Mercurial backend to use run_process() instead of execute(). This change updates the Mercurial implementation to use `run_process()` instead of `execute()`. Testing Done: Ran unit tests.	0c53b04a96a0cac5fa77ed196adbc9b0f3f26a35

Diff:

Revision 2 (+456 -308)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (fc986cc)