Summary

Update a few more places to use run_process() instead of execute().

Review Request #14482 — Created June 27, 2025 and submitted July 17, 2025, 10:19 p.m.

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

Groups

People

Description

This change updates the install and land commands to use the
run_process method, along with a few additional test cases.

Testing Done

Ran unit tests.

Commits

Summary	ID
Update a few more places to use run_process() instead of execute(). This change updates the install and land commands to use the `run_process` method, along with a few additional test cases. Testing Done: Ran unit tests.	d1703e4b3655142711023d39d836240f5a36339e

Issues

Description	From	Last Updated
This should be Sequence.	chipx86	June 28, 2025, 9:07 a.m.
Closing ) should be on the next line, aligned with python_version.	chipx86	June 28, 2025, 9:07 a.m.
This can use the common chaining form for run_process(): return ( run_process(...) .stdout.read() )	chipx86	June 28, 2025, 9:07 a.m.

flake8 passed.

JSHint passed.

rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be Sequence.
```
rbtools/commands/tests/test_main.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Closing ) should be on the next line, aligned with python_version.
```

rbtools/commands/tests/test_main.py (Diff revision 1)

The issue has been resolved. Show all issues

This can use the common chaining form for run_process():

return (
    run_process(...)
    .stdout.read()
)

Oops:

return (
    run_process(...)
    .stdout
    .read()
)

Commits:

	Summary	ID
	Update a few more places to use run_process() instead of execute(). This change updates the install and land commands to use the `run_process` method, along with a few additional test cases. Testing Done: Ran unit tests.	3cd1e98ed487e5ea56dd9f5cbb56b8b9ebd608de
	Update a few more places to use run_process() instead of execute(). This change updates the install and land commands to use the `run_process` method, along with a few additional test cases. Testing Done: Ran unit tests.	d1703e4b3655142711023d39d836240f5a36339e

Diff:

Revision 2 (+132 -104)

	rbtools/commands/install.py
	rbtools/commands/land.py
	rbtools/commands/tests/test_main.py
	rbtools/utils/tests/test_source_tree.py

flake8 passed.

JSHint passed.

Ship it!

Ship it!