Update rbtools.clients.tests.test_scanning to not use execute().

 






 

 


  Review Request #14481
  —
  Created June 27, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The execute() method has been deprecated for a while, but we didn't

actually do anything about that since the warning was hidden behind an

environment variable.


This change updates the rbtools.clients.tests.test_scanning module to

use run_process() instead, and tweaks our BaseSCMClientTestCase

definition to allow us to define test cases that use [None] as the

client (since this test case needs some of the machinery from that but

doesn't instantiate a specific client class).

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update rbtools.clients.tests.test_scanning to not use execute().
     
The `execute()` method has been deprecated for a while, but we didn't
actually do anything about that since the warning was hidden behind an
environment variable.

This change updates the `rbtools.clients.tests.test_scanning` module to
use `run_process()` instead, and tweaks our BaseSCMClientTestCase
definition to allow us to define test cases that use `[None]` as the
client (since this test case needs some of the machinery from that but
doesn't instantiate a specific client class).

Testing Done:
Ran unit tests.

    

   
  		
  6834f0a27d4a33ddc110d4f67539fe706a71d9b9
  David Trowbridge
 


 
  
 
 
  
   
    

     Update rbtools.clients.tests.test_scanning to not use execute().
     
The `execute()` method has been deprecated for a while, but we didn't
actually do anything about that since the warning was hidden behind an
environment variable.

This change updates the `rbtools.clients.tests.test_scanning` module to
use `run_process()` instead, and tweaks our BaseSCMClientTestCase
definition to allow us to define test cases that use `[None]` as the
client (since this test case needs some of the machinery from that but
doesn't instantiate a specific client class).

Testing Done:
Ran unit tests.

    

   
  		
  9260de05adb25a0001c559ba5787725f83b372a8
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/tests/__init__.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...