Summary

Update rbtools.clients.tests.test_scanning to not use execute().

Review Request #14481 — Created June 27, 2025 and submitted July 11, 2025, 9:13 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The execute() method has been deprecated for a while, but we didn't
actually do anything about that since the warning was hidden behind an
environment variable.

This change updates the rbtools.clients.tests.test_scanning module to
use run_process() instead, and tweaks our BaseSCMClientTestCase
definition to allow us to define test cases that use [None] as the
client (since this test case needs some of the machinery from that but
doesn't instantiate a specific client class).

Testing Done

Ran unit tests.

Commits

Summary	ID
Update rbtools.clients.tests.test_scanning to not use execute(). The `execute()` method has been deprecated for a while, but we didn't actually do anything about that since the warning was hidden behind an environment variable. This change updates the `rbtools.clients.tests.test_scanning` module to use `run_process()` instead, and tweaks our BaseSCMClientTestCase definition to allow us to define test cases that use `[None]` as the client (since this test case needs some of the machinery from that but doesn't instantiate a specific client class). Testing Done: Ran unit tests.	9260de05adb25a0001c559ba5787725f83b372a8

Summary

Update rbtools.clients.tests.test_scanning to not use execute().

The `execute()` method has been deprecated for a while, but we didn't actually do anything about that since the warning was hidden behind an environment variable. This change updates the `rbtools.clients.tests.test_scanning` module to use `run_process()` instead, and tweaks our BaseSCMClientTestCase definition to allow us to define test cases that use `[None]` as the client (since this test case needs some of the machinery from that but doesn't instantiate a specific client class). Testing Done: Ran unit tests.

9260de05adb25a0001c559ba5787725f83b372a8

Issues

Description	From	Last Updated
Meant to say: I don't actually see any code in here but typing changes. Nothing involving run_process() or execute().	chipx86	June 27, 2025, 5:42 p.m.
This needs to be Optional[...], since this is going to be executed at runtime. Only 3.10+ supports this.	chipx86	June 28, 2025, 9:06 a.m.
But then this could be \| None.	chipx86	June 28, 2025, 9:06 a.m.

flake8 passed.

JSHint passed.

rbtools/clients/tests/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

This needs to be Optional[...], since this is going to be executed at runtime. Only 3.10+ supports this.

rbtools/clients/tests/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
But then this could be | None.
```

The issue has been dropped. Show all issues

Meant to say: I don't actually see any code in here but typing changes. Nothing involving run_process() or execute().

david June 27, 2025, 5:43 p.m.

The test_scanning.py file has the execute-related changes.

Commits:

	Summary	ID
	Update rbtools.clients.tests.test_scanning to not use execute(). The `execute()` method has been deprecated for a while, but we didn't actually do anything about that since the warning was hidden behind an environment variable. This change updates the `rbtools.clients.tests.test_scanning` module to use `run_process()` instead, and tweaks our BaseSCMClientTestCase definition to allow us to define test cases that use `[None]` as the client (since this test case needs some of the machinery from that but doesn't instantiate a specific client class). Testing Done: Ran unit tests.	6834f0a27d4a33ddc110d4f67539fe706a71d9b9
	Update rbtools.clients.tests.test_scanning to not use execute(). The `execute()` method has been deprecated for a while, but we didn't actually do anything about that since the warning was hidden behind an environment variable. This change updates the `rbtools.clients.tests.test_scanning` module to use `run_process()` instead, and tweaks our BaseSCMClientTestCase definition to allow us to define test cases that use `[None]` as the client (since this test case needs some of the machinery from that but doesn't instantiate a specific client class). Testing Done: Ran unit tests.	9260de05adb25a0001c559ba5787725f83b372a8

Diff:

Revision 2 (+40 -40)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_scanning.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (8ea5353)