Add support for newer Sphinx versions, fix up some related warnings.

 






 

 


  Review Request #14476
  —
  Created June 25, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  beanbag-docutils
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
This change adds support for Sphinx 8.0 to our pyproject.toml and

tox.ini files, and fleshes out the tox configuration a bit for wider

version compatibility checking.


This also fixes a few warnings that were popping up when using

collect_files against Sphinx 7.4:


    

  • The default for collect_file_patterns was set to a dict, but it was
    
  used as a list.
    • 

  • The "rebuild" parameter for app.add_config_value() has changed from a
    
  simple bool to a string defining when to rebuild. The string version
    
  is supported in all our supported versions.
    • 

  • The comparison against Sphinx's src_dir warned that we should use
    
pathlib.Path or os.fspath instead of a string.
    • 


 








  


 
 

  
Ran tests via tox.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add support for newer Sphinx versions, fix up some related warnings.
     
This change adds support for Sphinx 8.0 to our pyproject.toml and
tox.ini files, and fleshes out the tox configuration a bit for wider
version compatibility checking.

This also fixes a few warnings that were popping up when using
collect_files against Sphinx 7.4:

- The default for `collect_file_patterns` was set to a dict, but it was
  used as a list.
- The "rebuild" parameter for app.add_config_value() has changed from a
  simple bool to a string defining when to rebuild. The string version
  is supported in all our supported versions.
- The comparison against Sphinx's `src_dir` warned that we should use
  `pathlib.Path` or `os.fspath` instead of a string.

Testing Done:
Ran tests via tox.

    

   
  		
  8fd5eef901fe4f92a5256c2f577859b701f7846d
  David Trowbridge
 


 
  
 
 
  
   
    

     Add support for newer Sphinx versions, fix up some related warnings.
     
This change adds support for Sphinx 8.0 to our pyproject.toml and
tox.ini files, and fleshes out the tox configuration a bit for wider
version compatibility checking.

This also fixes a few warnings that were popping up when using
collect_files against Sphinx 7.4:

- The default for `collect_file_patterns` was set to a dict, but it was
  used as a list.
- The "rebuild" parameter for app.add_config_value() has changed from a
  simple bool to a string defining when to rebuild. The string version
  is supported in all our supported versions.
- The comparison against Sphinx's `src_dir` warned that we should use
  `pathlib.Path` or `os.fspath` instead of a string.

Testing Done:
Ran tests via tox.

    

   
  		
  1f7a7f267b6f9d697c96d33de54bfadaa59f516d
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      beanbag_docutils/sphinx/ext/collect_files.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...