Summary

Add/update typing for rbtools.utils.users.

Review Request #14473 — Created June 24, 2025 and submitted June 27, 2025, 12:37 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds missing type hints for the methods in
rbtools.utils.users, and fixes up a couple more places where we were
just using Resource instead of specific subclasses. While I was in
here I also switched this to use a named logger.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add/update typing for rbtools.utils.users. This change adds missing type hints for the methods in `rbtools.utils.users`, and fixes up a couple more places where we were just using `Resource` instead of specific subclasses. While I was in here I also switched this to use a named logger. Testing Done: Ran unit tests.	950039929cfc57759304fdeaa8cf96f040ded99b

Issues

Description	From	Last Updated
These are missing their types.	chipx86	June 25, 2025, 1:44 p.m.
Same here. And same with the methods below.	chipx86	June 25, 2025, 1:44 p.m.

flake8 passed.

JSHint passed.

rbtools/utils/users.py (Diff revision 1)

The issue has been resolved. Show all issues

These are missing their types.

rbtools/utils/users.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
And same with the methods below.
```

Commits:

	Summary	ID
	Add/update typing for rbtools.utils.users. This change adds missing type hints for the methods in `rbtools.utils.users`, and fixes up a couple more places where we were just using `Resource` instead of specific subclasses. While I was in here I also switched this to use a named logger. Testing Done: Ran unit tests.	8b008a2340f62e6314fb74e9ef882df92a02e717
	Add/update typing for rbtools.utils.users. This change adds missing type hints for the methods in `rbtools.utils.users`, and fixes up a couple more places where we were just using `Resource` instead of specific subclasses. While I was in here I also switched this to use a named logger. Testing Done: Ran unit tests.	950039929cfc57759304fdeaa8cf96f040ded99b

Diff:

Revision 2 (+134 -36)

Show changes

rbtools/utils/users.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (6beec96)