flake8
passed.
JSHint
passed.
Add a new cancelled state for status updates.
Review Request #14466 — Created June 20, 2025 and submitted
This change adds a new cancelled state that can be set for status
updates. At the moment, this displays the same as error states, but it
has a default description of "cancelled" (for updates that do not have
explicit description text set), and it does not show a "Retry" button
for services that allow manually triggering retries.
- Ran unit tests.
- Used this in conjunction with some code in rbintegrations.
- Commits:
-
Summary ID b95f9801cb00c4f5e2ca570deb4414d90844fbf3 e4731285836e7f9473ef113e614bc71313408818
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
I don't know what it is but this form of
ifstatement just looks like a syntax error to me every time, like some line got missed.We normally use this form for this kind of comparison:
if state in {..., ..., ...}: ...But I had another thought. Since we're going through this series of lookups and conditionals for every single
StatusUpdateon one of the most-used pages in Review Board, perhaps we should just make a type-to-class map and do a direct lookup from that. That'd reduce complexity of this call path a fair amount.