Summary

Bring type annotations for rbtools.api up to date.

Review Request #14454 — Created June 10, 2025 and submitted July 17, 2025, 9:09 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change primarily replaces Optional[] and Union[] with the new

union syntax where appropriate. There's a few additional cleanups

sprinkled in as well.

Testing Done

Ran unit tests.

Commits

Summary	ID
Bring type annotations for rbtools.api up to date. This change primarily replaces `Optional[]` and `Union[]` with the new union syntax where appropriate. There's a few additional cleanups sprinkled in as well. Testing Done: Ran unit tests.	80b640e56a6fcc357f95c14939752201546cb2eb

Issues

Description	From	Last Updated
While here, let's rename this so we're not using the name of a builtin.	chipx86	June 26, 2025, 9:45 a.m.
We may want to localize these strings. If we do, we'll need the prior form. It's clearly been this way …	chipx86	June 26, 2025, 9:48 a.m.
We can probably remove the blank line now, since these don't run up against each other as much.	chipx86	July 17, 2025, 9:07 p.m.
Same here.	chipx86	July 17, 2025, 9:09 p.m.
This should probably be a Sequence[str].	chipx86	June 26, 2025, 9:48 a.m.
Should these (and similar) be Mapping?	chipx86	June 26, 2025, 9:49 a.m.
This should probably be Mapping now.	chipx86	June 26, 2025, 9:49 a.m.
Same here.	chipx86	June 26, 2025, 9:49 a.m.

flake8 passed.

JSHint passed.

rbtools/api/decode.py (Diff revision 1)
The issue has been resolved. Show all issues
```
While here, let's rename this so we're not using the name of a builtin.
```

rbtools/api/errors.py (Diff revision 1)

The issue has been resolved. Show all issues

We may want to localize these strings. If we do, we'll need the prior form. It's clearly been this way a while so it's not any kind of priority, but just noting it.

rbtools/api/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should probably be a Sequence[str].
```
rbtools/api/resource/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should these (and similar) be Mapping?
```
rbtools/api/resource/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should probably be Mapping now.
```
rbtools/api/resource/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Commits:

	Summary	ID
	Bring type annotations for rbtools.api up to date. This change primarily replaces `Optional[]` and `Union[]` with the new union syntax where appropriate. There's a few additional cleanups sprinkled in as well. Testing Done: Ran unit tests.	090f8c7eac8e4b1c9058d0c0379a1043d3717bfe
	Bring type annotations for rbtools.api up to date. This change primarily replaces `Optional[]` and `Union[]` with the new union syntax where appropriate. There's a few additional cleanups sprinkled in as well. Testing Done: Ran unit tests.	80b640e56a6fcc357f95c14939752201546cb2eb

Diff:

Revision 2 (+972 -882)

Show changes

	rbtools/api/cache.py
	rbtools/api/client.py
	rbtools/api/decode.py
	rbtools/api/errors.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/resource/api_token.py
	rbtools/api/resource/base.py
	24 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

rbtools/api/errors.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

We can probably remove the blank line now, since these don't run up against each other as much.

rbtools/api/errors.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Same here.
```

Status:: Completed
Change Summary:: Pushed to master (4db098d)