Summary

Update ReviewRequestPageData unit tests for the manual status update bug fix.

Review Request #14447 — Created May 20, 2025 and discarded Nov. 19, 2025, 10:06 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

~~14445~~

Reviewers

Groups

reviewboard

People

Description

This updates the queries for the ReviewRequestPageDataTests.test_get_entries
unit test to account for the changes from /r/14445. That change fixed
a bug where review request owners weren't able to run manual status
updates on their own review requests. I had originally written the
change on release-7.1.x, but moved it to release-7.x since a customer
who's running 7.0.3 needs it. The ReviewRequestPageDataTests on 7.0.3
don't even check the queries, so this change will make sure the unit
tests are right when we eventually merge the bug fix into 7.1.x.

Testing Done

Ran unit tests.

Commits

Summary	ID
Update ReviewRequestPageData unit tests for the manual status update bug fix. This updates the queries for the `ReviewRequestPageDataTests.test_get_entries` unit test to account for the changes from /r/14445. That change fixed a bug where review request owners weren't able to run manual status updates on their own review requests. I had originally written the change on release-7.1.x, but moved it to release-7.x since a customer who's running 7.0.3 needs it. The `ReviewRequestPageDataTests` on 7.0.3 don't even check the queries, so this change will make sure the unit tests are right when we eventually merge the bug fix into 7.1.x.	abf4da1bd50af5591cd0a5a96adaf00b3c8a4df8

Summary

Update ReviewRequestPageData unit tests for the manual status update bug fix.

This updates the queries for the `ReviewRequestPageDataTests.test_get_entries` unit test to account for the changes from /r/14445. That change fixed a bug where review request owners weren't able to run manual status updates on their own review requests. I had originally written the change on release-7.1.x, but moved it to release-7.x since a customer who's running 7.0.3 needs it. The `ReviewRequestPageDataTests` on 7.0.3 don't even check the queries, so this change will make sure the unit tests are right when we eventually merge the bug fix into 7.1.x.

abf4da1bd50af5591cd0a5a96adaf00b3c8a4df8

Issues

Description	From	Last Updated
We have a utility function for this: reviewboard.accounts.testing.queries.get_user_permissions_equeries().	chipx86	Nov. 19, 2025, 6:48 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/reviews/tests/test_review_request_page_data.py (Diff revision 1)

The issue has been dropped. Show all issues

We have a utility function for this: reviewboard.accounts.testing.queries.get_user_permissions_equeries().

Status:: Discarded
Change Summary:: The change in /r/14445 was optimized, so no new queries were added.