• 
      

    Fix unit tests for new ship-it dialog.

    Review Request #14443 — Created May 19, 2025 and submitted — Latest diff uploaded

    Information

    Review Board
    release-7.1.x

    Reviewers

    The unit test for the new ship-it dialog that attempted to change the
    confirmation preference must have been written while the user sessions
    settings code was still in flux, and wasn't properly skipping the code
    that actually saved the setting. This resulted in a bad PUT to the
    server and the ship-it dialog being permanently visible on the screen.

    This change fixes the test so the storeSettings() method isn't
    actually invoked, but resolves the promise, allowing things to proceed.

    Ran js-tests.

    Commits

    Files