This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-7.1.x (7421374)

Summary

Use KeyValueForm getter/setter methods in DiffSettingsForm.

Review Request #14436 — Created May 13, 2025 and submitted 2 weeks ago

Information

Owner

david*

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

The DiffSettingsForm has a few things which are handled specially (in
order to serialize and deserialize certain settings where the UI doesn't
map trivially to the settings keys). These were written to read and
write directly from the siteconfig.

This change makes it so those use the base KeyValueForm
get_key_value() and set_key_value() methods instead. The
implementation of those ends up doing the same thing as the current
code, but will allow us to subclass this form in RBCommons and override
those methods to try reading and writing from the LocalSite instead.

Testing Done


Ran unit tests.
Edited diff settings and verified that it all still worked correctly.

Commits

Summary	ID
Use KeyValueForm getter/setter methods in DiffSettingsForm. The `DiffSettingsForm` has a few things which are handled specially (in order to serialize and deserialize certain settings where the UI doesn't map trivially to the settings keys). These were written to read and write directly from the `siteconfig`. This change makes it so those use the base `KeyValueForm` `get_key_value()` and `set_key_value()` methods instead. The implementation of those ends up doing the same thing as the current code, but will allow us to subclass this form in RBCommons and override those methods to try reading and writing from the `LocalSite` instead. Testing Done: - Ran unit tests. - Edited diff settings and verified that it all still worked correctly.	f71ddb2699402d55e9d6b61c6af593f2fce273c2

Summary

Use KeyValueForm getter/setter methods in DiffSettingsForm.

The `DiffSettingsForm` has a few things which are handled specially (in order to serialize and deserialize certain settings where the UI doesn't map trivially to the settings keys). These were written to read and write directly from the `siteconfig`. This change makes it so those use the base `KeyValueForm` `get_key_value()` and `set_key_value()` methods instead. The implementation of those ends up doing the same thing as the current code, but will allow us to subclass this form in RBCommons and override those methods to try reading and writing from the `LocalSite` instead. Testing Done: - Ran unit tests. - Edited diff settings and verified that it all still worked correctly.

f71ddb2699402d55e9d6b61c6af593f2fce273c2

Issues