flake8
passed.
JSHint
passed.
Include user profile settings in review request page Etag calculation.
Review Request #14428 — Created May 8, 2025 and submitted
This change includes the user's profile settings when calculating the Etag
for the review request detail page. Today, this is useful to prevent
caching in the scenario where a user updates their Quick Access list from
the diff viewer page, and then navigates back to the review request page.
This will also help prevent caching issues for any similar settings in the
future.
- Ran unit tests.
- Added an item to my quick access list from the diff viewer page,
navigated to the review request page and saw that the page wasn't
cached. - Confirmed that the page still caches correctly when the quick access
list hasn't changed.
| Summary | ID |
|---|---|
| e2e2ac51f5e83335e62caafb98273ac6c4308391 |
- Summary:
-
Include Quick Access actions in review request page data Etag calculation.Include user profile settings in review request page Etag calculation.
- Description:
-
~ This change includes the user's Quick Access actions list when
~ calculating the Etag for the review request detail page. This prevents ~ This change includes the user's profile settings when calculating the Etag
~ for the review request detail page. Today, this is useful to prevent caching in the scenario where a user updates their Quick Access list from ~ the diff viewer page, and then navigates back to the review request page. ~ the diff viewer page, and then navigates back to the review request page. + This will also help prevent caching issues for any similar settings in the + future. - Commits:
-
Summary ID 97e98eae8a99ebdc9136183a40cfd06d890336d4 e2e2ac51f5e83335e62caafb98273ac6c4308391
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
