Use the local site aware session URL when updating User session settings.

Review Request #14427 — Created May 7, 2025 and submitted — Latest diff uploaded

Information

Review Board
release-7.1.x

Reviewers

We recently added new User session settings for customizing a Quick Access
hotbar for actions, and for toggling the Ship It! confirmation dialog.
The session API endpoint now handles updating these settings. However,
when calling the User session API endpoint from our frontend, we failed
to plumb through the local site to the request URL. This lead to a 404
response on local site servers (such as on RBCommons).

This change passes the local site for the current review request through
to the API request. Now the User session settings can be customized as
intended on local site servers. For a user that has access to multiple
local sites, the settings are shared accross all the local sites.

  • Ran unit tests, but these currently fail due to issues unrelated to
    this change.

Tested the following on a local site, and a non-local site:
- Tested toggling the Ship It! confirmation.
- Tested customizing the Quick Access actions hotbar.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Plumb through the local site when updating User session settings.
We recently added new User session settings for customizing a Quick Access hotbar for actions, and for toggling the Ship It! confirmation dialog. The session API endpoint now handles updating these settings. However, when calling the User session API endpoint from our frontend, we failed to plumb through the local site to the request URL. This lead to a 404 response on local site servers (such as on RBCommons). This change passes the local site for the current review request through to the API request. Now the User session settings can be customized as intended on local site servers. For a user that has access to multiple local sites, the settings are shared accross all the local sites.
8b3ca44f15381dc60af23ba4ba0d9d75c272766a Michelle Aubin
Plumb through the local site when updating User session settings.
We recently added new User session settings for customizing a Quick Access hotbar for actions, and for toggling the Ship It! confirmation dialog. The session API endpoint now handles updating these settings. However, when calling the User session API endpoint from our frontend, we failed to plumb through the local site to the request URL. This lead to a 404 response on local site servers (such as on RBCommons). This change passes the local site for the current review request through to the API request. Now the User session settings can be customized as intended on local site servers. For a user that has access to multiple local sites, the settings are shared accross all the local sites.
c0ebd898724b0af0f8bf00bcfe5e493e6911483c Michelle Aubin
reviewboard/static/rb/js/common/models/userSessionModel.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
Loading...