Add typing for diff opcodes.

 






 

 


  Review Request #14418
  —
  Created May 2, 2025 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates diff opcodes to use explicitly typed tuples. The

opcodes created by the Differ implementation have a tag and ranges,

and then the opcode generator adds an additional metadata field. In the

interest of avoiding any changes, we therefore have separate definitions

for both steps.

 








  


 
 

  
    

  • Did a bunch of smoke testing of diff generation and saw that
    
  everything still worked correctly.
    • 

  • Ran unit tests.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add typing for diff opcodes.
     
This change updates diff opcodes to use explicitly typed tuples. The
opcodes created by the `Differ` implementation have a tag and ranges,
and then the opcode generator adds an additional metadata field. In the
interest of avoiding any changes, we therefore have separate definitions
for both steps.

Testing Done:
- Did a bunch of smoke testing of diff generation and saw that
  everything still worked correctly.
- Ran unit tests.

    

   
  		
  6961dc9470b3655bda576024c5e1c517818f1aa3
  David Trowbridge
 


 
  
 
 
  
   
    

     Add typing for diff opcodes.
     
This change updates diff opcodes to use explicitly typed tuples. The
opcodes created by the `Differ` implementation have a tag and ranges,
and then the opcode generator adds an additional metadata field. In the
interest of avoiding any changes, we therefore have separate definitions
for both steps.

Testing Done:
- Did a bunch of smoke testing of diff generation and saw that
  everything still worked correctly.
- Ran unit tests.

    

   
  		
  f79f187458dcc42cf79371d2bc4670665d895ff8
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/opcode_generator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...