This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (54eecc3)

Summary

Fix up typing for things that just used generic resources.

Review Request #14413 — Created April 30, 2025 and submitted 1 week, 6 days ago

Information

Owner

david*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

There were a handful of places where we had added type annotations to
things prior to all the API work, and were just using generic
ListResource/ItemResource/Resource for those. This fixes them up to use
the newly-defined resource subclasses for those annotations.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix up typing for things that just used generic resources. There were a handful of places where we had added type annotations to things prior to all the API work, and were just using generic ListResource/ItemResource/Resource for those. This fixes them up to use the newly-defined resource subclasses for those annotations. Testing Done: Ran unit tests.	8479972044e06560ab38deea1deece818279adf2

Issues

Description	From	Last Updated
It wasn't clear why this was where it was. I think this will be more readable if we assert after …	chipx86	1 month ago
This needs to be indented 1 more level.	chipx86	1 week, 6 days ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/utils/repository.py (Diff revision 1)

The issue has been resolved. Show all issues

It wasn't clear why this was where it was. I think this will be more readable if we assert after the fetch. Especially since we're making comparisons on this variable up above.

Change Summary:


Move the requested line
Fix up a few more instances I found of raw ItemResource and ListResource

Commits:

	Summary	ID
	Fix up typing for things that just used generic resources. There were a handful of places where we had added type annotations to things prior to all the API work, and were just using generic ListResource/ItemResource/Resource for those. This fixes them up to use the newly-defined resource subclasses for those annotations. Testing Done: Ran unit tests.	df0becf806002bf062db486332962c93977fc85a
	Fix up typing for things that just used generic resources. There were a handful of places where we had added type annotations to things prior to all the API work, and were just using generic ListResource/ItemResource/Resource for those. This fixes them up to use the newly-defined resource subclasses for those annotations. Testing Done: Ran unit tests.	8479972044e06560ab38deea1deece818279adf2

Diff:

Revision 2 (+222 -118)

Show changes

	rbtools/api/resource/review_request.py
	rbtools/clients/clearcase.py
	rbtools/clients/svn.py
	rbtools/clients/base/repository.py
	rbtools/clients/base/scmclient.py
	rbtools/commands/review.py
	rbtools/commands/setup_repo.py
	rbtools/commands/base/commands.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/clients/clearcase.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs to be indented 1 more level.
```

Status:: Completed
Change Summary:: Pushed to master (54eecc3)